Merge pull request #6721 from guardian/ahe/knip-ignoreExportsUsedInFile

Change Knip `ignoreExportsUsedInFile` to false and fix

support-frontend/assets/components/button/_sharedButton.tsx

@@ -6,7 +6,7 @@ import { classNameWithModifiers } from 'helpers/utilities/utilities';
 import './button.scss';
 
 // ----- PropTypes ----- //
-export const Appearances = {
+const Appearances = {
 	primary: 'primary',
 	secondary: 'secondary',
 	tertiary: 'tertiary',
@@ -17,7 +17,7 @@ export const Appearances = {
 	greyHollow: 'greyHollow',
 	disabled: 'disabled',
 };
-export const Sides = {
+const Sides = {
 	right: 'right',
 	left: 'left',
 };
@@ -83,5 +83,5 @@ export const defaultProps = {
 	modifierClasses: [],
 };
 SharedButton.defaultProps = { ...defaultProps };
-export type { SharedButtonPropTypes, IconSide, Appearance };
+export type { SharedButtonPropTypes };
 export default SharedButton;

support-frontend/assets/components/button/anchorButton.tsx

@@ -4,7 +4,7 @@ import SharedButton, { defaultProps } from './_sharedButton';
 import './button.scss';
 
 // ----- Render ----- //
-export type PropTypes = SharedButtonPropTypes & {
+type PropTypes = SharedButtonPropTypes & {
 	'aria-label'?: string | null | undefined;
 	href: string;
 	onClick?: () => void;

support-frontend/assets/components/checkoutBenefits/checkoutBenefitsListData.tsx

@@ -21,7 +21,7 @@ type TierUnlocks = {
 	countryGroupId: CountryGroupId;
 };
 
-export type CheckListData = {
+type CheckListData = {
 	isChecked: boolean;
 	text?: JSX.Element;
 	maybeGreyedOut?: SerializedStyles;

support-frontend/assets/components/content/content.tsx

@@ -6,7 +6,7 @@ import 'helpers/types/option';
 import './content.scss';
 
 // ---- Types ----- //
-export const Appearances = {
+const Appearances = {
 	white: 'white',
 	grey: 'grey',
 	highlight: 'highlight',

support-frontend/assets/components/csr/csrMode.ts

@@ -96,9 +96,4 @@ const useCsrCustomerData = (
 const csrUserName = (csrCustomerData: CsrCustomerData): string =>
 	`${csrCustomerData.csr.firstName} ${csrCustomerData.csr.lastName}`;
 
-export {
-	useCsrCustomerData,
-	isSalesforceDomain,
-	csrUserName,
-	parseCustomerData,
-};
+export { useCsrCustomerData, csrUserName, parseCustomerData };

support-frontend/assets/components/dialog/dialog.tsx

@@ -48,7 +48,7 @@ const backdrop = css`
 	width: 100%;
 `;
 
-export type PropTypes = {
+type PropTypes = {
 	closeDialog: () => void;
 	styled?: boolean;
 	open?: boolean;

support-frontend/assets/components/directDebit/directDebitProgressiveDisclosure/directDebitForm.tsx

@@ -51,7 +51,7 @@ const mapDispatchToProps = {
 
 const connector = connect(mapStateToProps, mapDispatchToProps);
 
-export type PropTypes = ConnectedProps<typeof connector> & {
+type PropTypes = ConnectedProps<typeof connector> & {
 	allErrors: Array<Record<string, string>>;
 	buttonText: string;
 	submissionErrorHeading: string;

support-frontend/assets/components/footerCompliant/FooterWithPromoTerms.tsx

@@ -7,10 +7,7 @@ import {
 	Quarterly,
 } from 'helpers/productPrice/billingPeriods';
 import type { FulfilmentOptions } from 'helpers/productPrice/fulfilmentOptions';
-import {
-	Domestic,
-	NoFulfilmentOptions,
-} from 'helpers/productPrice/fulfilmentOptions';
+import { Domestic } from 'helpers/productPrice/fulfilmentOptions';
 import { NoProductOptions } from 'helpers/productPrice/productOptions';
 import type { ProductPrices } from 'helpers/productPrice/productPrices';
 import { getPromotion } from 'helpers/productPrice/promotions';
@@ -176,24 +173,4 @@ function GuardianWeeklyFooter({
 	);
 }
 
-function DigitalFooter({
-	productPrices,
-	orderIsAGift,
-	country,
-}: FooterWithPromoTermsProps): JSX.Element {
-	const termsConditionsLink = orderIsAGift
-		? 'https://www.theguardian.com/help/2020/nov/24/gift-digital-subscriptions-terms-and-conditions'
-		: 'https://www.theguardian.com/info/2014/aug/06/guardian-observer-digital-subscriptions-terms-conditions';
-
-	return (
-		<FooterWithPromoTerms
-			productPrices={productPrices}
-			orderIsAGift={orderIsAGift}
-			country={country}
-			fulfillmentOption={NoFulfilmentOptions}
-			termsConditionsLink={termsConditionsLink}
-		/>
-	);
-}
-
-export { DigitalFooter, GuardianWeeklyFooter };
+export { GuardianWeeklyFooter };

support-frontend/assets/components/headers/header/header.tsx

@@ -9,12 +9,12 @@ import Links from '../links/links';
 import MobileMenuToggler from './mobileMenuToggler';
 import './header.scss';
 
-export type PropTypes = {
+type PropTypes = {
 	utility?: JSX.Element;
 	countryGroupId: CountryGroupId;
 	display?: 'navigation' | 'checkout' | 'guardianLogo' | void;
 };
-export type State = {
+type State = {
 	isTestUser: boolean | null | undefined;
 };
 

support-frontend/assets/components/headers/mobileMenu/mobileMenu.tsx

@@ -9,7 +9,7 @@ export type Position = {
 	y: number;
 };
 
-export type PropTypes = {
+type PropTypes = {
 	onClose: () => void;
 	utility: ReactNode;
 	links: ReactNode;

support-frontend/assets/components/page/heroRoundel.tsx

@@ -11,8 +11,8 @@ import {
 import type { ReactElement, ReactNode } from 'react';
 import { digitalSubscriptionsBlue } from 'stylesheets/emotion/colours';
 
-export const roundelSizeMob = 100;
-export const roundelSize = 180;
+const roundelSizeMob = 100;
+const roundelSize = 180;
 
 const heroRoundelStyles = css`
 	display: flex;

support-frontend/assets/components/page/pageTitle.tsx

@@ -61,7 +61,7 @@ const header = css`
 		}
 	}
 `;
-export const pageTitle = css`
+const pageTitle = css`
 	${titlepiece42};
 	font-weight: bold;
 	z-index: 10;
@@ -88,7 +88,7 @@ export const pageTitle = css`
 	}
 `;
 
-function PageTitle({
+export function PageTitle({
 	title,
 	theme,
 	cssOverrides,
@@ -103,8 +103,3 @@ function PageTitle({
 		</div>
 	);
 }
-
-PageTitle.defaultProps = {
-	cssOverrides: '',
-};
-export default PageTitle;

support-frontend/assets/components/payPalPaymentButton/payPalButtonProps.ts

@@ -8,7 +8,7 @@ import type {
 import { routes } from 'helpers/urls/routes';
 import { logException } from 'helpers/utilities/logger';
 
-export type PayPalButtonControls = {
+type PayPalButtonControls = {
 	enable?: () => void;
 	disable?: () => void;
 };

support-frontend/assets/components/paymentFrequencyTabs/paymentFrequenncyTabs.tsx

@@ -18,7 +18,7 @@ const tabPanelStyles = css`
 	}
 `;
 
-export type TabProps = {
+type TabProps = {
 	id: ContributionType;
 	labelText: string;
 	selected: boolean;

support-frontend/assets/components/personalDetails/personalDetails.tsx

@@ -132,5 +132,3 @@ export function PersonalDetails({
 		</div>
 	);
 }
-
-export default PersonalDetails;

support-frontend/assets/components/priceLabel/priceLabel.tsx

@@ -5,7 +5,7 @@ import type { ProductPrice } from 'helpers/productPrice/productPrices';
 import { showPrice } from 'helpers/productPrice/productPrices';
 import { getAppliedPromo, hasDiscount } from 'helpers/productPrice/promotions';
 
-export type PropTypes = {
+type PropTypes = {
 	productPrice: ProductPrice;
 	billingPeriod: BillingPeriod;
 	className: string;

support-frontend/assets/components/productPage/productPageHero/productPageHero.tsx

@@ -146,5 +146,4 @@ ProductPageHeroHeader.defaultProps = {
 	orderIsAGift: false,
 	giftImage: null,
 };
-export { HeroWrapper, HeroHeading, ProductPageHeroHeader };
-export default ProductPageHero;
+export { HeroWrapper };

support-frontend/assets/components/stripeCardForm/stripeCardForm.tsx

@@ -22,7 +22,7 @@ const inlineContainer = css`
 	}
 `;
 
-export type StripeCardFormProps = {
+type StripeCardFormProps = {
 	onCardNumberChange: (event: StripeCardNumberElementChangeEvent) => void;
 	onExpiryChange: (event: StripeCardExpiryElementChangeEvent) => void;
 	onCvcChange: (event: StripeCardCvcElementChangeEvent) => void;

support-frontend/assets/components/subscriptionCheckouts/cancellationPolicy.tsx

@@ -1,6 +1,6 @@
 import Text from 'components/text/text';
 
-export const cancellationCopy = {
+const cancellationCopy = {
 	title: 'You can cancel any time',
 	body: 'There is no set time on your agreement with us so you can end your subscription whenever you wish',
 };

support-frontend/assets/components/subscriptionCheckouts/personalDetails.tsx

@@ -23,7 +23,7 @@ const paragraphWithButton = css`
 	${textSans17};
 `;
 
-export type PropTypes = {
+type PropTypes = {
 	firstName: string;
 	setFirstName: (firstName: string) => void;
 	lastName: string;

support-frontend/assets/components/subscriptionCheckouts/personalDetailsGift.tsx

@@ -9,7 +9,7 @@ import 'helpers/subscriptionsForms/formFields';
 const marginBotom = css`
 	margin-bottom: ${space[6]}px;
 `;
-export type PropTypes = {
+type PropTypes = {
 	firstNameGiftRecipient: string;
 	setFirstNameGift: (firstName: string) => void;
 	lastNameGiftRecipient: string;
@@ -57,41 +57,4 @@ function PersonalDetailsGift(props: PropTypes): JSX.Element {
 	);
 }
 
-function PersonalDetailsDigitalGift(props: PropTypes): JSX.Element {
-	return (
-		<div>
-			<TextInput
-				cssOverrides={marginBotom}
-				id="firstNameGiftRecipient"
-				data-qm-masking="blocklist"
-				label="First name"
-				type="text"
-				value={props.firstNameGiftRecipient}
-				onChange={(e) => props.setFirstNameGift(e.target.value)}
-				error={firstError('firstNameGiftRecipient', props.formErrors)}
-			/>
-			<TextInput
-				cssOverrides={marginBotom}
-				id="lastNameGiftRecipient"
-				data-qm-masking="blocklist"
-				label="Last name"
-				type="text"
-				value={props.lastNameGiftRecipient}
-				onChange={(e) => props.setLastNameGift(e.target.value)}
-				error={firstError('lastNameGiftRecipient', props.formErrors)}
-			/>
-			<TextInput
-				cssOverrides={marginBotom}
-				id="emailGiftRecipient"
-				data-qm-masking="blocklist"
-				label="Email"
-				type="email"
-				onChange={(e) => props.setEmailGift(e.target.value)}
-				value={props.emailGiftRecipient}
-				error={firstError('emailGiftRecipient', props.formErrors)}
-			/>
-		</div>
-	);
-}
-
-export { PersonalDetailsGift, PersonalDetailsDigitalGift };
+export { PersonalDetailsGift };

support-frontend/assets/components/subscriptionCheckouts/stripeForm/stripeForm.tsx

@@ -40,7 +40,7 @@ import {
 } from './composedStripeElements';
 
 // Types
-export type StripeFormPropTypes = {
+type StripeFormPropTypes = {
 	allErrors: Array<FormError<FormField>>;
 	stripeKey: string;
 	submitForm: () => void;

support-frontend/assets/components/thankYou/guardianAdLite/addressCta.tsx

@@ -10,7 +10,7 @@ const btnStyleOverrides = css`
 	margin-bottom: ${space[5]}px;
 `;
 
-export type AddressCtaProp = {
+type AddressCtaProp = {
 	copy: string;
 	address: string;
 	hasArrow?: boolean;

support-frontend/assets/components/thankYou/thankyouModules.tsx

@@ -23,7 +23,7 @@ const firstColumnContainer = css`
 	}
 `;
 
-export interface ThankYouModulesProps {
+interface ThankYouModulesProps {
 	isSignedIn?: boolean;
 	showNewspaperArchiveBenefit: boolean;
 	thankYouModules: ThankYouModuleType[];

support-frontend/assets/helpers/abTests/abtest.ts

@@ -46,13 +46,9 @@ export type Audience = {
 	breakpoint?: BreakpointRange;
 };
 
-export type AudienceType =
-	| IsoCountry
-	| CountryGroupId
-	| 'ALL'
-	| 'CONTRIBUTIONS_ONLY';
+type AudienceType = IsoCountry | CountryGroupId | 'ALL' | 'CONTRIBUTIONS_ONLY';
 
-export type Audiences = {
+type Audiences = {
 	[key in AudienceType]?: Audience;
 };
 

support-frontend/assets/helpers/abTests/helpers.ts

@@ -14,7 +14,7 @@ type NonEmptyAmountsTestArray = [
 	...AmountsTestWithVariants[],
 ];
 
-export const FALLBACK_AMOUNTS: NonEmptyAmountsTestArray = [
+const FALLBACK_AMOUNTS: NonEmptyAmountsTestArray = [
 	{
 		testName: 'FALLBACK_AMOUNTS__GBPCountries',
 		liveTestName: '',