Add CI with GitHub Actions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
add-github-actions-ci
branch
from
5f59153 to
8e1e216
Compare
Currently, running 'sbt test' fails, and so CI will reflect that.
rtyley
force-pushed
the
add-github-actions-ci
branch
from
8e1e216 to
0a21d64
Compare
rtyley
commented
Jan 11, 2024
| cache: sbt | ||
| - name: Build and Test | ||
| run: sbt -v +test | ||
| - uses: EnricoMi/publish-unit-test-result-action@v2 |
There was a problem hiding this comment.
I haven't personally used https://github.com/EnricoMi/publish-unit-test-result-action before, but I see that it is used in other Content Pipeline repos, like https://github.com/guardian/content-api-scala-client/blob/ed01efc55163e072601012a205861ce5467d5a5e/.github/workflows/testonpush.yml#L34
Previously, I've used https://github.com/test-summary/action, which I think is maybe more limited? Happy to try something new!
Test Results11 tests 5 ✅ 24s ⏱️ For more details on these failures, see this check. Results for commit 0a21d64. |
Divs-B
approved these changes
Jan 11, 2024
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
sbt teston themainbranch fails, and so we see that here with this PR in the CI results!Having CI is obviously good in general, but also this should help with evaluating #28 (which appears to actually fix the tests, at least locally) and #30, which adds automated release support with
gha-scala-library-release-workflow.I think it would be best to merge this PR first, then rebase #28 on top to see it fix the tests.