Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Typescript 4.9.5 and set as peerDependency of generated package #28

Conversation

georgeblahblah
Copy link
Contributor

What does this change?

Typescript doesn't follow semantic versioning (microsoft/TypeScript#39269). This means that there could be breaking changes in caret (^) ranges.

This change:

  • upgrades to Typescript 4.9.5 for building the typescript files
  • adds Typescript ~4.9.5 as a peerDependency of the generated npm package
  • adds a scroogeTypescriptPeerDependencies setting to enable plugin users to add peer dependencies to the package.json
  • fixes a mismatched type in the decode-encode module

Warning
I think this should be released as a major version bump

How to test

sbt test

@georgeblahblah georgeblahblah requested a review from a team as a code owner March 2, 2023 17:20
@rtyley rtyley mentioned this pull request Jan 11, 2024
@rtyley rtyley changed the base branch from main to db-rt/updating-to-gh-scala-lib-release January 11, 2024 11:53
@rtyley rtyley force-pushed the db-rt/updating-to-gh-scala-lib-release branch from 6bc9764 to 75e6d07 Compare January 11, 2024 11:54
Typescript doesn't follow semantic versioning (microsoft/TypeScript#39269). This means that there could be breaking changes in caret (`^`) ranges.

This change:
- upgrades to Typescript 4.9.5 for building the typescript files
- adds Typescript ~4.9.5 as a `peerDependency` of the generated npm package
- adds a `scroogeTypescriptPeerDependencies` setting to enable plugin users to add peer dependencies to the `package.json`
- fixes a mismatched type in the `decode-encode` module
@rtyley rtyley force-pushed the gb/typescript-tilde-peerdep branch from 798cbd8 to 83e8d19 Compare January 11, 2024 11:55
Copy link

Test Results

11 tests  ±0   11 ✅ +6   27s ⏱️ +3s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌  - 6 

Results for commit 83e8d19. ± Comparison against base commit 75e6d07.

@rtyley
Copy link
Member

rtyley commented Jan 11, 2024

@georgeblahblah just to let you know, I've rebased this PR on top of #31 (to add CI) and #30 (to allow publishing a preview release that can be tried out on a consumer of the scrooge-extras library).

As you can see in the comment above, this PR fixes the tests and CI passes!

@georgeblahblah
Copy link
Contributor Author

@rtyley thanks for the heads up! This PR has some knock-on effects to consumers and I'm still not 100% sure those effects are desirable. I've raised #32 which will fix tests in this repository instead.

@georgeblahblah
Copy link
Contributor Author

Closing this for now as it's stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants