fix: bump minCapacity from 15 => 30 #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgorrie
changed the title
ParisaTork
approved these changes
Sep 1, 2023
|
Size Change: 0 B 🆕 Total Size: 0 B |
AshCorr
approved these changes
Sep 1, 2023
|
And we're live |
ioannakok
added a commit
that referenced
this pull request
Oct 31, 2023
`minCapacity` was bumped from 15 to 30 in #8724. After the fronts migration was completed, it seemed that 15 instances weren't holding up with the new traffic we were sending. That was a hotfix and there is upcoming work to split our stacks (#8351) but until we reach this point we would like to see whether we could handle the traffic with 25 instances. This change is part of the research we're doing to optimise how we scale: #9322. Co-authored-by: George B <[email protected]> Co-authored-by: Ravi <[email protected]>
ioannakok
added a commit
that referenced
this pull request
Oct 31, 2023
`minCapacity` was bumped from 15 to 30 in #8724. After the fronts migration was completed, it seemed that 15 instances weren't holding up with the new traffic we were sending. That was a hotfix and there is upcoming work to split our stacks (#8351) but until we reach this point we would like to see whether we could handle the traffic with 25 instances. This change is part of the research we're doing to optimise how we scale: #9322. Co-authored-by: George B <[email protected]> Co-authored-by: Ravi <[email protected]>
ioannakok
added a commit
that referenced
this pull request
Nov 1, 2023
`minCapacity` was bumped from 15 to 30 in #8724. After the fronts migration was completed, it seemed that 15 instances weren't holding up with the new traffic we were sending. That was a hotfix and there is upcoming work to split our stacks (#8351) but until we reach this point we would like to see whether we could handle the traffic with 25 instances. This change is part of the research we're doing to optimise how we scale: #9322. Co-authored-by: George B <[email protected]> Co-authored-by: Ravi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bumps the min capacity from 15-30 as it seems the minimum isn't holding up with all the new traffic we're sending it.
This is a hotfix until we split our stacks, and can start setting scaling policies and capacities for specifically for each of our stacks.