infra: cdk launch template #8567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: DanielCliftonGuardian [email protected] Co-authored-by: Charlotte [email protected]
Co-Authored-By: Charlotte Emms <[email protected]>
Co-Authored-By: Charlotte Emms <[email protected]> Co-Authored-By: Daniel Clifton <[email protected]>
…-rendering into cdk/InternalLoadBalancer
Co-Authored-By: Parisa Tork <[email protected]> Co-Authored-By: Charlotte Emms <[email protected]>
Co-Authored-By: Parisa Tork <[email protected]> Co-Authored-By: Charlotte Emms <[email protected]>
|
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a launch template to CDK.
Why?
As part of our migration to CDK, so that we can override the prop
associatePublicIpAddresson the autoscaling group since this needs to be set on the launch template instead. The launch template is normally auto generated in Gu CDK so this bypasses this in order to be able to have public IP addresses on our instances.