Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch load balancer type #8558

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Aug 11, 2023

What does this change?

Replaces CfnLoadBalancer with GuClassicLoadBalancer for the load balancer migration.

Why?

For the ASG (autoscaling group) migration, we want to be able to attach the ASG to our classic load balancer. This doesn't seem to be possible with the CfnLoadBalancer class as there's a type mismatch.

Turns out we can override some of the resulting cloudformation template with the propertiesToOverride field, which seems to do what we want it to. The only issue is that we have an extra orphaned security group which was created as part of the GuClassicLoadBalancer construct. We're planning on migrating from the classic LB to an application LB soon so this shouldn't make too much of a difference, especially as we don't actually use this additional security group anywhere.

This is possibly a slightly better solution anyway as we're using Gu CDK for all resources rather than partially using the Cfn AWS lib ones.

@github-actions
Copy link

Size Change: 0 B

Total Size: 656 kB

ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1168.modern.********************.js 19.2 kB
dotcom-rendering/dist/1244.modern.********************.js 869 B
dotcom-rendering/dist/1294.modern.********************.js 5.36 kB
dotcom-rendering/dist/1354.modern.********************.js 3.63 kB
dotcom-rendering/dist/1355.modern.********************.js 3.7 kB
dotcom-rendering/dist/1406.modern.********************.js 5.07 kB
dotcom-rendering/dist/1465.modern.********************.js 3.31 kB
dotcom-rendering/dist/1486.modern.********************.js 745 B
dotcom-rendering/dist/1848.modern.********************.js 644 B
dotcom-rendering/dist/187.modern.********************.js 3.22 kB
dotcom-rendering/dist/1948.modern.********************.js 1.88 kB
dotcom-rendering/dist/1987.modern.********************.js 3.25 kB
dotcom-rendering/dist/1997.modern.********************.js 745 B
dotcom-rendering/dist/2038.modern.********************.js 4.59 kB
dotcom-rendering/dist/2071.modern.********************.js 745 B
dotcom-rendering/dist/21.modern.********************.js 758 B
dotcom-rendering/dist/2126.modern.********************.js 885 B
dotcom-rendering/dist/2201.modern.********************.js 778 B
dotcom-rendering/dist/2228.modern.********************.js 901 B
dotcom-rendering/dist/2339.modern.********************.js 779 B
dotcom-rendering/dist/2494.modern.********************.js 779 B
dotcom-rendering/dist/2619.modern.********************.js 3.61 kB
dotcom-rendering/dist/275.modern.********************.js 697 B
dotcom-rendering/dist/2929.modern.********************.js 5.8 kB
dotcom-rendering/dist/3024.modern.********************.js 621 B
dotcom-rendering/dist/3146.modern.********************.js 6.52 kB
dotcom-rendering/dist/3239.modern.********************.js 5 kB
dotcom-rendering/dist/3358.modern.********************.js 638 B
dotcom-rendering/dist/3549.modern.********************.js 21.3 kB
dotcom-rendering/dist/356.modern.********************.js 827 B
dotcom-rendering/dist/3960.modern.********************.js 619 B
dotcom-rendering/dist/3968.modern.********************.js 4.76 kB
dotcom-rendering/dist/4113.modern.********************.js 757 B
dotcom-rendering/dist/4424.modern.********************.js 3.7 kB
dotcom-rendering/dist/4593.modern.********************.js 1.67 kB
dotcom-rendering/dist/4603.modern.********************.js 3.93 kB
dotcom-rendering/dist/4734.modern.********************.js 760 B
dotcom-rendering/dist/4811.modern.********************.js 2.54 kB
dotcom-rendering/dist/5021.modern.********************.js 963 B
dotcom-rendering/dist/5071.modern.********************.js 941 B
dotcom-rendering/dist/5141.modern.********************.js 3.91 kB
dotcom-rendering/dist/5210.modern.********************.js 1.32 kB
dotcom-rendering/dist/533.modern.********************.js 12.1 kB
dotcom-rendering/dist/5431.modern.********************.js 2.8 kB
dotcom-rendering/dist/5474.modern.********************.js 620 B
dotcom-rendering/dist/5974.modern.********************.js 744 B
dotcom-rendering/dist/6118.modern.********************.js 681 B
dotcom-rendering/dist/6192.modern.********************.js 2.29 kB
dotcom-rendering/dist/640.modern.********************.js 710 B
dotcom-rendering/dist/6437.modern.********************.js 867 B
dotcom-rendering/dist/6527.modern.********************.js 3.35 kB
dotcom-rendering/dist/6534.modern.********************.js 573 B
dotcom-rendering/dist/6541.modern.********************.js 812 B
dotcom-rendering/dist/6588.modern.********************.js 2.69 kB
dotcom-rendering/dist/6840.modern.********************.js 4.73 kB
dotcom-rendering/dist/7039.modern.********************.js 25.8 kB
dotcom-rendering/dist/7133.modern.********************.js 698 B
dotcom-rendering/dist/7174.modern.********************.js 4.18 kB
dotcom-rendering/dist/7305.modern.********************.js 886 B
dotcom-rendering/dist/7401.modern.********************.js 689 B
dotcom-rendering/dist/7498.modern.********************.js 3.62 kB
dotcom-rendering/dist/7569.modern.********************.js 4.55 kB
dotcom-rendering/dist/7688.modern.********************.js 815 B
dotcom-rendering/dist/786.modern.********************.js 477 B
dotcom-rendering/dist/8165.modern.********************.js 927 B
dotcom-rendering/dist/8170.modern.********************.js 491 B
dotcom-rendering/dist/8268.modern.********************.js 5.53 kB
dotcom-rendering/dist/8447.modern.********************.js 965 B
dotcom-rendering/dist/8505.modern.********************.js 556 B
dotcom-rendering/dist/8555.modern.********************.js 688 B
dotcom-rendering/dist/8622.modern.********************.js 859 B
dotcom-rendering/dist/8638.modern.********************.js 834 B
dotcom-rendering/dist/8769.modern.********************.js 2.77 kB
dotcom-rendering/dist/9490.modern.********************.js 829 B
dotcom-rendering/dist/9724.modern.********************.js 6.27 kB
dotcom-rendering/dist/9812.modern.********************.js 2.76 kB
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 411 B
dotcom-rendering/dist/AnimatePulsingDots-importable.modern.********************.js 387 B
dotcom-rendering/dist/atomIframe.modern.********************.js 516 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 3.35 kB
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.modern.********************.js 4.05 kB
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.19 kB
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.46 kB
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.47 kB
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 6.6 kB
dotcom-rendering/dist/Carousel-importable.modern.********************.js 6.41 kB
dotcom-rendering/dist/CarouselForNewsletters-importable.modern.********************.js 5.57 kB
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 473 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.79 kB
dotcom-rendering/dist/discussion.modern.********************.js 394 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 24.4 kB
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.83 kB
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 3 kB
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.53 kB
dotcom-rendering/dist/embedIframe.modern.********************.js 518 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.93 kB
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 2.98 kB
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 1.97 kB
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.42 kB
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 510 B
dotcom-rendering/dist/frameworks.modern.********************.js 20.8 kB
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.36 kB
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 9.83 kB
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.84 kB
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.42 kB
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 14.6 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 9.86 kB
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 5.05 kB
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.9 kB
dotcom-rendering/dist/index.modern.********************.js 34.2 kB
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 3.07 kB
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.8 kB
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 4.08 kB
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 4.47 kB
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 2.21 kB
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 484 B
dotcom-rendering/dist/LatestLinks-importable.modern.********************.js 4.41 kB
dotcom-rendering/dist/LightboxHash-importable.modern.********************.js 514 B
dotcom-rendering/dist/LightboxJavascript-importable.modern.********************.js 4.35 kB
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 5.14 kB
dotcom-rendering/dist/LiveblogRightMultipleAdSlots-importable.modern.********************.js 1.01 kB
dotcom-rendering/dist/Liveness-importable.modern.********************.js 3.74 kB
dotcom-rendering/dist/ManyNewsletterSignUp-importable.modern.********************.js 4.56 kB
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.58 kB
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.76 kB
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 5.36 kB
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.57 kB
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.79 kB
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 621 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 3.86 kB
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 483 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 480 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 478 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 460 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.06 kB
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.83 kB
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.55 kB
dotcom-rendering/dist/relativeTime.modern.********************.js 979 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.88 kB
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 4.76 kB
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.37 kB
dotcom-rendering/dist/sentry.modern.********************.js 766 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 4.07 kB
dotcom-rendering/dist/SetAdTargeting-importable.modern.********************.js 535 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.92 kB
dotcom-rendering/dist/shimport.modern.********************.js 2.79 kB
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 720 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 5.44 kB
dotcom-rendering/dist/SignInGateMain.modern.********************.js 2.97 kB
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 3.89 kB
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.72 kB
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 3.08 kB
dotcom-rendering/dist/Snow-importable.modern.********************.js 4.22 kB
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.43 kB
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 3.99 kB
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.33 kB
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.93 kB
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 3.08 kB
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 477 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 1.01 kB
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 3.07 kB
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.6 kB
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.93 kB
dotcom-rendering/dist/WeatherWrapper-importable.modern.********************.js 5.22 kB
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 953 B

compressed-size-action

@cemms1 cemms1 marked this pull request as ready for review August 14, 2023 08:48
@cemms1 cemms1 requested a review from a team as a code owner August 14, 2023 08:48
@cemms1 cemms1 merged commit 856dfda into cemms1/cdk-migrate-asg Aug 14, 2023
@cemms1 cemms1 deleted the cemms1/switch-lb-type branch August 14, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants