-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch load balancer type #8558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Replaces
CfnLoadBalancer
withGuClassicLoadBalancer
for the load balancer migration.Why?
For the ASG (autoscaling group) migration, we want to be able to attach the ASG to our classic load balancer. This doesn't seem to be possible with the
CfnLoadBalancer
class as there's a type mismatch.Turns out we can override some of the resulting cloudformation template with the
propertiesToOverride
field, which seems to do what we want it to. The only issue is that we have an extra orphaned security group which was created as part of theGuClassicLoadBalancer
construct. We're planning on migrating from the classic LB to an application LB soon so this shouldn't make too much of a difference, especially as we don't actually use this additional security group anywhere.This is possibly a slightly better solution anyway as we're using Gu CDK for all resources rather than partially using the
Cfn
AWS lib ones.