Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 7 Upgrade - AR #7622

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Storybook 7 Upgrade - AR #7622

merged 4 commits into from
Apr 26, 2023

Conversation

JamieB-gu
Copy link
Contributor

Why?

Upgrading to storybook 7 using the auto-migration. Based on the migration guide1 there aren't many changes required in this PR. The DCR equivalent is #7513.

Changes

  • Changed from the old "builder" pattern to the new "framework" pattern, specifying React with Webpack 5.
  • Switched to the new CLI commands, via the storybook package.
  • Updated to version 7.x of all available storybook packages.
  • Added storybook/addon-essentials - we were getting addon-related errors without this; it's also used in DCR.
  • Made use of the StoryFn type in a couple of places to fix type errors.
  • Migrated from .story.name to .storyName for naming stories.

Footnotes

  1. https://storybook.js.org/docs/react/migration-guide

- Updated all storybook dependencies to v7
- Added storybook package and new CLI commands
- Updated `main.js` to use framework instead of builders
@JamieB-gu JamieB-gu requested a review from a team as a code owner April 25, 2023 17:24
@JamieB-gu JamieB-gu linked an issue Apr 25, 2023 that may be closed by this pull request
4 tasks
Copy link
Contributor

@georgeblahblah georgeblahblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JamieB-gu JamieB-gu merged commit f74ab9a into main Apr 26, 2023
@JamieB-gu JamieB-gu deleted the storybook-7-ar branch April 26, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook 7 Upgrade
2 participants