Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook 7 Upgrade - DCR #7513

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Storybook 7 Upgrade - DCR #7513

merged 3 commits into from
Apr 26, 2023

Conversation

JamieB-gu
Copy link
Contributor

@JamieB-gu JamieB-gu commented Apr 4, 2023 •
edited
Loading

Why?

Upgrading to storybook 7 using the auto-migration. Based on the migration guide1 there aren't many changes required in this PR, although a couple of pre-requisite changes were made in #7560 and #7591.

Changes

  • Changed from the old "builder" pattern to the new "framework" pattern, specifying React with Webpack 5.
  • Switched to the new CLI commands, via the storybook package.
  • Updated to version 7.x of all available storybook packages.

Footnotes

  1. https://storybook.js.org/docs/react/migration-guide ↩

@github-actions
Copy link

github-actions bot commented Apr 4, 2023 •
edited
Loading

Size Change: -1 B (0%)

Total Size: 523 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/116.modern.********************.js 3.84 kB 0 B
dotcom-rendering/dist/1813.modern.********************.js 6.52 kB 0 B
dotcom-rendering/dist/1917.modern.********************.js 2.53 kB 0 B
dotcom-rendering/dist/2136.modern.********************.js 3.11 kB 0 B
dotcom-rendering/dist/2153.modern.********************.js 1.89 kB 0 B
dotcom-rendering/dist/2216.modern.********************.js 3.07 kB 0 B
dotcom-rendering/dist/2854.modern.********************.js 3.3 kB 0 B
dotcom-rendering/dist/3033.modern.********************.js 3.16 kB 0 B
dotcom-rendering/dist/344.modern.********************.js 11.6 kB 0 B
dotcom-rendering/dist/397.modern.********************.js 2.75 kB 0 B
dotcom-rendering/dist/3993.modern.********************.js 6.21 kB 0 B
dotcom-rendering/dist/4180.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/4730.modern.********************.js 3.61 kB 0 B
dotcom-rendering/dist/5153.modern.********************.js 2.28 kB 0 B
dotcom-rendering/dist/516.modern.********************.js 17.3 kB 0 B
dotcom-rendering/dist/5474.modern.********************.js 2.53 kB 0 B
dotcom-rendering/dist/6297.modern.********************.js 21.3 kB 0 B
dotcom-rendering/dist/6345.modern.********************.js 4.71 kB 0 B
dotcom-rendering/dist/6429.modern.********************.js 3.5 kB 0 B
dotcom-rendering/dist/6910.modern.********************.js 4.34 kB 0 B
dotcom-rendering/dist/6939.modern.********************.js 5.35 kB 0 B
dotcom-rendering/dist/7392.modern.********************.js 2.49 kB 0 B
dotcom-rendering/dist/7679.modern.********************.js 4.36 kB 0 B
dotcom-rendering/dist/7872.modern.********************.js 1.89 kB 0 B
dotcom-rendering/dist/8077.modern.********************.js 22.9 kB 0 B
dotcom-rendering/dist/9861.modern.********************.js 3.5 kB 0 B
dotcom-rendering/dist/9977.modern.********************.js 3.82 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 411 B 0 B
dotcom-rendering/dist/AnimatePulsingDots-importable.modern.********************.js 387 B 0 B
dotcom-rendering/dist/atomIframe.modern.********************.js 513 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 464 B 0 B
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.18 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.02 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.47 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 6.58 kB 0 B
dotcom-rendering/dist/Carousel-importable.modern.********************.js 5.28 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 475 B 0 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.81 kB 0 B
dotcom-rendering/dist/discussion.modern.********************.js 393 B 0 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 4.07 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.35 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 2.72 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.25 kB 0 B
dotcom-rendering/dist/embedIframe.modern.********************.js 519 B 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.93 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 3 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 2.52 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.41 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 509 B 0 B
dotcom-rendering/dist/frameworks.modern.********************.js 20.3 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.36 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 11.4 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.35 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.42 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 13.3 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 10.3 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 476 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.8 kB 0 B
dotcom-rendering/dist/index.modern.********************.js 30.8 kB -1 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.8 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 4.08 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 3.81 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 3.44 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 483 B 0 B
dotcom-rendering/dist/LabsHeader-importable.modern.********************.js 2.64 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 4.72 kB 0 B
dotcom-rendering/dist/Liveness-importable.modern.********************.js 5.52 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.32 kB 0 B
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.29 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 4.88 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.05 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.73 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 621 B 0 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 8.34 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 483 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 478 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 478 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 460 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.41 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.23 kB 0 B
dotcom-rendering/dist/relativeTime.modern.********************.js 974 B 0 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.05 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.54 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.37 kB 0 B
dotcom-rendering/dist/sentry.modern.********************.js 767 B 0 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 4.04 kB 0 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.94 kB 0 B
dotcom-rendering/dist/shimport.modern.********************.js 2.78 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 720 B 0 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 6.15 kB 0 B
dotcom-rendering/dist/SignInGateMain.modern.********************.js 2.94 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 3.84 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.45 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 2.82 kB 0 B
dotcom-rendering/dist/Snow-importable.modern.********************.js 4.26 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.17 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 3.93 kB 0 B
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.38 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 3.07 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 478 B 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 664 B 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 999 B 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 2.8 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.33 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.64 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 4.05 kB 0 B

compressed-size-action

@JamieB-gu JamieB-gu linked an issue Apr 6, 2023 that may be closed by this pull request
Storybook 7 Upgrade #7504
Closed
4 tasks
@JamieB-gu JamieB-gu changed the title Storybook 7 Upgrade Storybook 7 Upgrade - DCR Apr 6, 2023
@JamieB-gu JamieB-gu mentioned this pull request Apr 19, 2023
Merged
@JamieB-gu JamieB-gu marked this pull request as ready for review April 25, 2023 12:53
@JamieB-gu JamieB-gu requested a review from a team as a code owner April 25, 2023 12:53
@JamieB-gu JamieB-gu mentioned this pull request Apr 25, 2023
Merged
@JamieB-gu JamieB-gu merged commit 7c9ef86 into main Apr 26, 2023
@JamieB-gu JamieB-gu deleted the storybook-7 branch April 26, 2023 10:00
@cemms1 cemms1 mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgeblahblah georgeblahblah georgeblahblah approved these changes

Assignees
No one assigned
Labels
dotcom-rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook 7 Upgrade
2 participants
@JamieB-gu @georgeblahblah