-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare functionality #217
Merged
samarth52
merged 47 commits into
bog-changes-s23-merged
from
sophia/204-compare-functionality
Oct 20, 2023
Merged
Compare functionality #217
samarth52
merged 47 commits into
bog-changes-s23-merged
from
sophia/204-compare-functionality
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nhatnghiho
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on such a big ticket!! Aside from the TODOs you listed, here are a couple small stuff to change.
…m/gt-scheduler/website into sophia/204-compare-functionality
…m/gt-scheduler/website into sophia/204-compare-functionality
samarth52
changed the base branch from
bog-changes-s23
to
bog-changes-s23-merged
October 20, 2023 00:44
…ler/website into sophia/204-compare-functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #204
Adds some functionality to the compare panel
Known bugs:
To do:
CombinationContainer
back and standardize color when compare panel is onCourseContainer
when compare panel is onCourseContainer
when compare panel is onChecklist
UI Requirements
CombinationContainer
and export "fake" calendar should not be affected)Functional Requirements
FriendContext
and the friend collection must be updated when user removes a friend's scheduleFriendContext
and the friend collection must be updated when user gives their friend a nicknameHow to Test
In
src\components\Scheduler\index.tsx
line 20, change compare to true. Insrc\components\Calendar\index.tsx
line 53, change the schedules to whatever schedules you want to show on the Calendar.