Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare functionality #217

Merged
merged 47 commits into from
Oct 20, 2023

Conversation

sophiazlin
Copy link
Contributor

@sophiazlin sophiazlin commented Apr 2, 2023

Summary

Resolves #204

Adds some functionality to the compare panel

Known bugs:

  • The .frame class for the selected palette color doesn't work.
  • Colors change when the user swaps schedule versions bc colorMap is based on whatever version is currently selected. Will have to create a separate colorMap for friend schedules?
  • Removing / editing a friend / schedule (unless you are deleting the last remaining schedule?) will rerender whole page

To do:

  • Let calendar know when compare schedules is turned on and what schedules are selected.
  • Remove section for user's schedules on compare panel (since we are only going to display the user's current schedule)
  • Add CombinationContainer back and standardize color when compare panel is on
  • Standardize color in CourseContainer when compare panel is on
  • Add events from friends schedules to calendar
  • Allow users to still use CourseContainer when compare panel is on

Checklist

UI Requirements

  • The list of friend schedules on the Compare Panel view are pulled from FriendContext.
  • All time blocks show up correctly ("preview" calendars in CombinationContainer and export "fake" calendar should not be affected)
  • All time blocks of a given schedule have the same color, which is dictated by the color picker in the compare panel.
  • Disabling compare view removes all friend schedules on the calendar.
  • Popup for each time block must include the owner's name.

Functional Requirements

  • FriendContext and the friend collection must be updated when user removes a friend's schedule
  • FriendContext and the friend collection must be updated when user gives their friend a nickname

How to Test

In src\components\Scheduler\index.tsx line 20, change compare to true. In src\components\Calendar\index.tsx line 53, change the schedules to whatever schedules you want to show on the Calendar.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://gt-scheduler.github.io/website/pr-preview/pr-217/
on branch gh-pages at 2023-10-20 02:02 UTC

Copy link
Contributor

@nhatnghiho nhatnghiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on such a big ticket!! Aside from the TODOs you listed, here are a couple small stuff to change.

src/components/ComparisonPanel/index.tsx Outdated Show resolved Hide resolved
src/components/ComparisonPanel/index.tsx Outdated Show resolved Hide resolved
src/components/ComparisonContainer/index.tsx Outdated Show resolved Hide resolved
@samarth52 samarth52 changed the base branch from bog-changes-s23 to bog-changes-s23-merged October 20, 2023 00:44
@samarth52 samarth52 merged commit 49f9d5f into bog-changes-s23-merged Oct 20, 2023
3 checks passed
@samarth52 samarth52 deleted the sophia/204-compare-functionality branch October 20, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants