Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Comparison Functionalities #204

Open
7 tasks
nhatnghiho opened this issue Mar 14, 2023 · 0 comments
Open
7 tasks

Integrate Comparison Functionalities #204

nhatnghiho opened this issue Mar 14, 2023 · 0 comments
Labels
task Task issue for a current or past sprint

Comments

@nhatnghiho
Copy link
Contributor

nhatnghiho commented Mar 14, 2023

Description

Now that we have the Compare Panel to select schedules to compare, we want to actually connect it to the backend and display those schedules on the Calendar.

image

Refer to Figma for more design details.

Acceptance Criteria

UI Requirements

  • The list of friend schedules on the Compare Panel view are pulled from FriendContext.
  • All time blocks show up correctly ("preview" calendars in CombinationContainer and export "fake" calendar should not be affected)
  • All time blocks of a given schedule have the same color, which is dictated by the color picker in the compare panel.
  • Disabling compare view removes all friend schedules on the calendar.
  • Popup for each time block must include the owner's name.

Functional Requirements

  • FriendContext and the friend collection must be updated when user removes a friend's schedule
  • FriendContext and the friend collection must be updated when user gives their friend a nickname
@nhatnghiho nhatnghiho added the task Task issue for a current or past sprint label Mar 14, 2023
@sophiazlin sophiazlin mentioned this issue Apr 2, 2023
16 tasks
samarth52 added a commit that referenced this issue Oct 20, 2023
### Summary

Resolves #204 

<!-- What does this PR change and why? Discuss any breaking changes. -->
Adds some functionality to the compare panel

Known bugs: 
- [ ] The .frame class for the selected palette color doesn't work.
- [ ] Colors change when the user swaps schedule versions bc colorMap is
based on whatever version is currently selected. Will have to create a
separate colorMap for friend schedules?
- [x] Removing / editing a friend / schedule (unless you are deleting
the last remaining schedule?) will rerender whole page

To do: 
- [x] Let calendar know when compare schedules is turned on and what
schedules are selected.
- [x] Remove section for user's schedules on compare panel (since we are
only going to display the user's current schedule)
- [x] Add `CombinationContainer` back and standardize color when compare
panel is on
- [x] Standardize color in `CourseContainer` when compare panel is on
- [x] Add events from friends schedules to calendar
- [x] Allow users to still use `CourseContainer` when compare panel is
on

### Checklist

#### UI Requirements
- [ ] The list of friend schedules on the Compare Panel view are pulled
from FriendContext.
- [ ] All time blocks show up correctly ("preview" calendars in
`CombinationContainer` and export "fake" calendar should not be
affected)
- [ ] All time blocks of a given schedule have the same color, which is
dictated by the color picker in the compare panel.
- [ ] Disabling compare view removes all friend schedules on the
calendar.
- [ ] Popup for each time block must include the owner's name.

#### Functional Requirements
- [ ] `FriendContext` and the friend collection must be updated when
user removes a friend's schedule
- [ ] `FriendContext` and the friend collection must be updated when
user gives their friend a nickname

### How to Test
In `src\components\Scheduler\index.tsx` line 20, change compare to true.
In `src\components\Calendar\index.tsx` line 53, change the schedules to
whatever schedules you want to show on the Calendar.

---------

Co-authored-by: Nghi Ho <[email protected]>
Co-authored-by: Samarth Chandna <[email protected]>
Co-authored-by: nathangong <[email protected]>
Co-authored-by: EmilyAL001 <[email protected]>
Co-authored-by: Hailey Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task issue for a current or past sprint
Projects
None yet
Development

No branches or pull requests

1 participant