-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #54 Create run_julia wrapper #55
Conversation
I created the run_julia function and edited files related to how the command is called. Removed some files that had errors in their name and were created an issue with the new environment.
I also want to flag that the unit tests failed (see https://github.com/gslab-econ/gslab_make/actions/runs/3230092659/jobs/5288141596#step:5:368) because the test scripts were expecting the files with the extraneous characters (i.e., |
A follow-up to the previous comment: The error occurs when This error is also reported on this issue on the conda-forge GitHub. The
I am inclined towards the second option, as any errors related to unicode/ASCII characters would be caught by git. Let me know what you think @gentzkow @snairdesai. |
@jc-cisneros Seems you already tackled this, but I second that option (2) above makes intuitive sense. |
Pending revisions to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per revisions to #68 in gentzkow/template
, this looks good to go. Thanks @jc-cisneros!
This pull request closes #54. The way to test the new run_julia wrapper is described in gentzkow/template_archive#68.