Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #54 Create run_julia wrapper #55

Merged
merged 11 commits into from
Oct 22, 2022
Merged

Conversation

jc-cisneros
Copy link
Contributor

This pull request closes #54. The way to test the new run_julia wrapper is described in gentzkow/template_archive#68.

jccisneros added 2 commits October 11, 2022 12:08
I created the run_julia function and edited files related to how the command is called. Removed some files that had errors in their name and were created an issue with the new environment.
@jc-cisneros jc-cisneros linked an issue Oct 11, 2022 that may be closed by this pull request
2 tasks
@jc-cisneros
Copy link
Contributor Author

I also want to flag that the unit tests failed (see https://github.com/gslab-econ/gslab_make/actions/runs/3230092659/jobs/5288141596#step:5:368) because the test scripts were expecting the files with the extraneous characters (i.e., move_╬▓.txt) that were not compatible with the new Julia-capable conda environment. I will take a look at the test scripts and load the correct files.

@jc-cisneros
Copy link
Contributor Author

A follow-up to the previous comment:

The error occurs when template_julia is active (the only difference with template is that it has Julia installed). The following screenshot is the error message I get when running python run_all.py with the master branch of the gslab_make submodule:

Screen Shot 2022-10-11 at 2 27 43 PM

This error is also reported on this issue on the conda-forge GitHub. The template environment is using my local git installation, so the error is surely related to the MAC git discussed in the conda-forge issue. Julia's source code lives on GitHub, so it requires git as a dependency in the conda environment. Indeed the error is reproduced if -git is added to the template environment. Therefore we have the following choices:

  • Removing the git package from the conda environment and use the local version. This is the current default in template (i.e., installing git locally and not on the conda environment). A possible caveat is that the "local" git might produce the same error in other OS.
  • Adding the git package to the conda environment and removing both the files with extraneous characters and the gslab_make unit tests that tested the capacity to catch these characters.

I am inclined towards the second option, as any errors related to unicode/ASCII characters would be caught by git. Let me know what you think @gentzkow @snairdesai.

@snairdesai
Copy link
Contributor

@jc-cisneros Seems you already tackled this, but I second that option (2) above makes intuitive sense.

@snairdesai
Copy link
Contributor

snairdesai commented Oct 21, 2022

Pending revisions to gentzkow/template #68 based on my latest review, this looks good to go @jc-cisneros!

Copy link
Contributor

@snairdesai snairdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per revisions to #68 in gentzkow/template, this looks good to go. Thanks @jc-cisneros!

@jc-cisneros jc-cisneros merged commit 6e4f046 into master Oct 22, 2022
@jc-cisneros jc-cisneros deleted the 54-create-run_julia branch October 22, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create run_julia wrapper
2 participants