Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create run_julia wrapper #54

Closed
2 tasks done
jc-cisneros opened this issue Oct 10, 2022 · 2 comments · Fixed by gentzkow/template_archive#68 or #55
Closed
2 tasks done

Create run_julia wrapper #54

jc-cisneros opened this issue Oct 10, 2022 · 2 comments · Fixed by gentzkow/template_archive#68 or #55
Assignees
@jc-cisneros

Comments

@jc-cisneros
Copy link
Contributor

jc-cisneros commented Oct 10, 2022 •
edited
Loading

Per https://github.com/gentzkow/CommitFlex/issues/112#issuecomment-1262897169, we could add support for Julia in the gslab_make module. Tests will be run in template(see gentzkow/template_archive#67)

Task list
@jc-cisneros jc-cisneros self-assigned this Oct 10, 2022
@jc-cisneros jc-cisneros mentioned this issue Oct 10, 2022
Closed
2 tasks
@jc-cisneros
Copy link
Contributor Author

Update:
I created the first version of the run_julia wrapper in 6dad136

This was referenced Oct 11, 2022
Merged
Merged
@jc-cisneros jc-cisneros linked a pull request Oct 11, 2022 that will close this issue
PR for #54 Create run_julia wrapper #55
Merged
jc-cisneros pushed a commit that referenced this issue Oct 11, 2022
#54 Remove unicode unit tests
0fc2ae2
jc-cisneros pushed a commit that referenced this issue Oct 13, 2022
#54 Minor change in Julia call
e1b348d
jc-cisneros added a commit that referenced this issue Oct 22, 2022
@jc-cisneros
Merge pull request #55 from gslab-econ/54-create-run_julia
6e4f046 
PR for #54 Create run_julia wrapper
@jc-cisneros jc-cisneros reopened this Oct 22, 2022
@jc-cisneros
Copy link
Contributor Author

Summary:

On this issue we created a run_julia wrapper for the gslab_make module. The wrapper was successfully tested on the template repository (see the Issue on Template and its Pull Request for more information).

Changes were brought to master on PR #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jc-cisneros jc-cisneros

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jc-cisneros