Replace *testing.T with testing.TestingT (#908) #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WithDefaultRetryableErrors function now takes a testing.TestingT argument instead of *testing.T to allow for anything that implements the testing.TestingT interface to be used. This allows for GinkgoT() to be used in tests utilizing the ginkgo testing framework.
brikis98
approved these changes
May 24, 2021
|
Tests passed! Merging now. |
|
Since #905 fixes a very similar issue, going to wait for that before doing a new release. |
This was referenced May 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WithDefaultRetryableErrorsfunction now takes a testing.TestingTargument instead of *testing.T to allow for anything that implements the
testing.TestingT interface to be used. This allows for GinkgoT() to be
used in tests utilizing the ginkgo testing framework.
Test output for all terraform tests is available here: https://gist.github.com/cbascom/81d2c6659beace706072329594e7068c
There is a test failure unrelated to my changes. I have terraform v0.15.4 installed locally. The current terratest is not compatible with that terraform version since the
planWithNoChangesRegexpused by theGetResourceCountEfunction looks forNo changes\. Infrastructure is up-to-date\.instead of(\033\[32m)?No changes\.(\033\[0m\033\[1m)? Your infrastructure matches the configuration\.which is output by my terraform version.I didn't see how you handle compatibility with different terraform versions so I didn't include this update in this PR, but let me know how you want to handle that. I can submit a new issue for that if necessary.