Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 904 #905

Merged
merged 2 commits into from
May 31, 2021
Merged

Fix issue 904 #905

merged 2 commits into from
May 31, 2021

Conversation

ApostolosBenisis
Copy link

No description provided.

@ApostolosBenisis ApostolosBenisis mentioned this pull request May 19, 2021
Closed
@brikis98 brikis98 linked an issue May 24, 2021 that may be closed by this pull request
Use testing.TestingT instead of *testing.T in terraform/var-file.go #904
Closed
brikis98
brikis98 previously approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I'll kick off tests now.

@brikis98
Copy link
Member

Pre-commit hooks failed:

[INFO] Initializing environment for https://github.com/gruntwork-io/pre-commit.
goimports................................................................Failed
- hook id: goimports
- files were modified by this hook

modules/terraform/var-file.go

Please run goimports!

@brikis98 brikis98 mentioned this pull request May 25, 2021
Merged
@ApostolosBenisis
Copy link
Author

@brikis98 sorry for the inconvenience, hopefully now the Pre-commit hooks will not fail

Run goimports
Rebased on latest master and pushed

@ApostolosBenisis ApostolosBenisis requested a review from brikis98 May 28, 2021 23:38
@brikis98
Copy link
Member

Great, thanks! I'll re-run tests now.

@brikis98
Copy link
Member

Hm, I think CircleCi is having some sort of outage right now...

@ApostolosBenisis
Copy link
Author

@brikis98 The CircleCI Jobs queuing and slow UI loading incident was resolved and the build-and-test workflow run successfully

brikis98
brikis98 approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed! Merging now.

@brikis98 brikis98 merged commit d8f161e into gruntwork-io:master May 31, 2021
@brikis98
Copy link
Member

https://github.com/gruntwork-io/terratest/releases/tag/v0.35.1

This was referenced May 31, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use testing.TestingT instead of *testing.T in terraform/var-file.go
2 participants
@ApostolosBenisis @brikis98