[Azure] Add sovereign cloud support for Storage #868
Conversation
|
[Microsoft CI Bot] TL;DR; success 👍 You can check the status of the CI Pipeline logs here ; https://github.com/aztfmod/terratest/actions/runs/745238923 |
| @@ -191,6 +192,7 @@ func GetStorageAccountClientE(subscriptionID string) (*storage.AccountsClient, e | |||
| } | |||
|
|
|||
| // GetStorageBlobContainerClientE creates a storage container client. | |||
There was a problem hiding this comment.
remove the method GetStorageBlobContainerClientE as it is no longer used
There was a problem hiding this comment.
I mentioned this somewhere, but I can't find where I said this, so reiterating it here:
Since this is a public method, removing it means we will have to cut a backward incompatible release. It would be a bit of a pain for us to release a backward incompatible release for each of these changes. I think it would be better to keep these in so that we can merge all of these changes as backward compatible patch releases, and then at the very end once all the files are updated, we can have one big PR to remove all the Get.*Client functions and cut one backward incompatible release.
There was a problem hiding this comment.
sounds good @yorinasub17 , I approved it and it is ready for review @gruntwork-terratest-terragrunt
| @@ -174,6 +174,7 @@ func GetStorageAccountPropertyE(storageAccountName, resourceGroupName, subscript | |||
| } | |||
|
|
|||
| // GetStorageAccountClientE creates a storage account client. | |||
| // TODO: remove in next version | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This PR resolves the Base URI for the Resource Group module to support sovereign cloud.
Addresses #811, fixes #861
cc. @rguthriemsft