Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Add sovereign cloud support for MySQL #862

Closed

Conversation

davidkpiano
Copy link
Contributor

This PR resolves the Base URI for the MySQL module to support sovereign cloud.

Addresses #811, fixes #858

cc. @rguthriemsft

@hattan
Copy link
Contributor

hattan commented Apr 8, 2021

[Microsoft CI Bot] TL;DR; success 👍

You can check the status of the CI Pipeline logs here ; https://github.com/aztfmod/terratest/actions/runs/730444481

Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidkpiano Mostly LGTM. Just rebase from master to pull latest

modules/azure/mysql.go Show resolved Hide resolved
@hattan
Copy link
Contributor

hattan commented Apr 20, 2021

[Microsoft CI Bot] TL;DR; success 👍

You can check the status of the CI Pipeline logs here ; https://github.com/aztfmod/terratest/actions/runs/768301876

Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @gruntwork-io/gruntwork-terratest-terragrunt ready for your review

@yorinasub17
Copy link
Contributor

NOTE: Looks like there is a merge conflict now that we merged some of the other PRs.

@davidkpiano
Copy link
Contributor Author

Superseded by #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure] Add sovereign cloud support for MySQL
6 participants