-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Add sovereign cloud support for MySQL #862
Conversation
[Microsoft CI Bot] TL;DR; success 👍 You can check the status of the CI Pipeline logs here ; https://github.com/aztfmod/terratest/actions/runs/730444481 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidkpiano Mostly LGTM. Just rebase from master to pull latest
[Microsoft CI Bot] TL;DR; success 👍 You can check the status of the CI Pipeline logs here ; https://github.com/aztfmod/terratest/actions/runs/768301876 |
…rratest into davidkpiano/811-mysql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @gruntwork-io/gruntwork-terratest-terragrunt ready for your review
NOTE: Looks like there is a merge conflict now that we merged some of the other PRs. |
Superseded by #884 |
This PR resolves the Base URI for the MySQL module to support sovereign cloud.
Addresses #811, fixes #858
cc. @rguthriemsft