Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #736: updated Azure VM tags map init #757

Merged
merged 11 commits into from
Feb 11, 2021
Merged

Fix #736: updated Azure VM tags map init #757

merged 11 commits into from
Feb 11, 2021

Conversation

davesee
Copy link
Contributor

@davesee davesee commented Jan 8, 2021 •
edited
Loading

Updated VM Tags module and tests

Fixes #736
Original PR #641
@rguthriemsft

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/512698858

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/512698858

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; failure 🤦

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/512698858

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; success 👍

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/512698858

@rguthriemsft
Copy link
Contributor

[Microsoft CI Bot] TL;DR; success 👍

You can check the status of the CI Pipeline logs here ; https://github.com/rguthriemsft/terratest/actions/runs/544006247

@davesee
Copy link
Contributor Author

davesee commented Feb 6, 2021 •
edited
Loading

Resolved comments and completed successful CI/CD.

@HadwaAbdelhalem

HadwaAbdelhalem
HadwaAbdelhalem approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , @yorinasub17 the PR is ready for your review

yorinasub17
yorinasub17 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17 yorinasub17 merged commit fd8775e into gruntwork-io:master Feb 11, 2021
@davesee davesee deleted the davesee/736 branch March 24, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadwaAbdelhalem HadwaAbdelhalem HadwaAbdelhalem approved these changes

@yorinasub17 yorinasub17 yorinasub17 approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure module
4 participants
@davesee @rguthriemsft @yorinasub17 @HadwaAbdelhalem