Fix #736: updated Azure VM tags map init (#757)

* Updated VM tags module and tests

* Enforce complex password requirement

* Added tag variable

* Enforce complex password requirement mysqldb

* Added missing build tag resgrp_test

* Updated unit test

* Updated module and reverted unit test.

* Updated revert.

* Updated tag test

* Updated to use output, removed additional updates

* Removed extra changes

examples/azure/terraform-azure-vm-example/main.tf

@@ -127,6 +127,11 @@ resource "azurerm_virtual_machine" "vm_example" {
     provision_vm_agent = true
   }
 
+  tags = {
+    "Version"     = "0.0.1"
+    "Environment" = "dev"
+  }
+
   depends_on = [random_password.rand]
 }
 

examples/azure/terraform-azure-vm-example/outputs.tf

@@ -58,3 +58,7 @@ output "vm_name" {
 output "vm_size" {
   value = azurerm_virtual_machine.vm_example.vm_size
 }
+
+output "vm_tags" {
+  value = azurerm_virtual_machine.vm_example.tags
+}

modules/azure/compute.go

@@ -240,12 +240,12 @@ func GetVirtualMachineTags(t testing.TestingT, vmName string, resGroupName strin
 // GetVirtualMachineTagsE gets the Tags of the specified Virtual Machine as a map.
 func GetVirtualMachineTagsE(vmName string, resGroupName string, subscriptionID string) (map[string]string, error) {
 	// Setup a blank map to populate and return
-	var tags map[string]string
+	tags := make(map[string]string)
 
 	// Get VM Object
 	vm, err := GetVirtualMachineE(vmName, resGroupName, subscriptionID)
 	if err != nil {
-		return nil, err
+		return tags, err
 	}
 
 	// Range through existing tags and populate above map accordingly

test/azure/terraform_azure_vm_example_test.go

@@ -113,6 +113,7 @@ func testInformationOfVM(t *testing.T, terraformOptions *terraform.Options, subs
 	expectedImageSKU := terraform.OutputList(t, terraformOptions, "vm_image_sku")
 	expectedImageVersion := terraform.OutputList(t, terraformOptions, "vm_image_version")
 	expectedAvsName := terraform.Output(t, terraformOptions, "availability_set_name")
+	expectedVMTags := terraform.OutputMap(t, terraformOptions, "vm_tags")
 
 	// Check if the Virtual Machine exists.
 	assert.True(t, azure.VirtualMachineExists(t, virtualMachineName, resourceGroupName, subscriptionID))
@@ -131,6 +132,10 @@ func testInformationOfVM(t *testing.T, terraformOptions *terraform.Options, subs
 	// The AVS ID returned from the VM is always CAPS so ignoring case in the assertion.
 	actualexpectedAvsName := azure.GetVirtualMachineAvailabilitySetID(t, virtualMachineName, resourceGroupName, subscriptionID)
 	assert.True(t, strings.EqualFold(expectedAvsName, actualexpectedAvsName))
+
+	// Check the assigned Tags of the VM, assert empty if no tags.
+	actualVMTags := azure.GetVirtualMachineTags(t, virtualMachineName, resourceGroupName, "")
+	assert.Equal(t, expectedVMTags, actualVMTags)
 }
 
 // These tests check the OS Disk and Attached Managed Disks for the Azure Virtual Machine.