Adding a basic framework for a new Azure module #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes support for: - Getting authorized access based on env variables or arguments - 2 basic tests against Azure Virtual Machines, just as a starting point
drmmarsunited
requested review from
brikis98,
Etiene,
robmorgan and
yorinasub17
as code owners
brikis98
reviewed
Jul 27, 2019
There was a problem hiding this comment.
This looks like a great start. Thank you! 👍
I left a few minor code style comments in the PR. The only major thing before merging this is:
- Add a simple, minimal Azure example to the
examplesfolder. - Add a corresponding test for that example to the
testfolder. - Update the root README to mention Azure support.
|
Work has been busy, still working on this. Also duplicating region selection functionality from the AWS module into the Azure module, small complexities there. |
added 4 commits
July 31, 2019 07:46
Renamed variables for easier reading Refactored Azure tests to use assert/require from Testify Updated GetSizeOfVirtualMachineE to return custom type instead of string casting Adding region helpers and respective tests to mimic AWS module
Renaming Azure subscription ID env var to match Terraform provider spec Fixing subnet mistake in Terraform example code
|
This is ready for re-review now. Thanks! |
|
@mcalhoun Could you review this one? You have more experience with Azure than I do! |
|
How's it going? Anyone had a chance to take a look here? |
This was referenced Aug 21, 2019
mcalhoun
approved these changes
Aug 23, 2019
|
Released as v0.18.4 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes support for:
The idea here was just to socialize an approach to the beginnings of an Azure module. In true open source fashion, someone else contributed an approach to the Azure model 2 hours before me here haha!
I'm trying to approach the testing methods in a way that somewhat closely aligns to the existing methods for AWS, just to keep the style in line with the rest of the suite. Happy to take consolidated feedback from you (the maintainers) and work together with the author of the other PR on an approach that will accelerate Azure capabilities in Terratest.
Issue link: #89
Related PR: #332