Initial contribution of Azure module #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmiodice
requested review from
brikis98,
Etiene,
robmorgan and
yorinasub17
as code owners
Closed
For a project I'm working on I have been writing Terratest style code to help make assertions about infrastructure in Azure. I want to contribute these back to Terratest to give back to the awesome open source community you have going here. I am initially submitting a subset of the work I have done in order to get initial feedback. Once this PR is merged I'll go ahead and update the remaining modules that I have to be consistent with the PR comments provided here. Modules in this commit: * Azure Container Registry - Webhook + Network ACL queries * Azure Networking - VNET/Subnet queries Modules that I will contribute in follow on PRs: * Azure CLI - Log into local azure CLI * WebApp - Query for WebApp config and CD Webhook metadata * KeyVault - Inspect network ACLs for KeyVault
nmiodice
force-pushed
the
niiodice/features/azure-module-p1
branch
from
35441b0 to
1395c9d
Compare
|
Thank you for the PR! Adding Azure support is wonderful 🍺 Two requests:
Thanks! |
|
Please see #89 for the status on Terratest with Azure. In particular, we're starting some work around it, and when that work is done, we'll be able to come back to this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I'm working on I have been writing Terratest style code to
help make assertions about infrastructure in Azure. I want to contribute
these back to Terratest to give back to the awesome open source
community you have going here.
I am initially submitting a subset of the work I have done in order to
get initial feedback. Once this PR is merged I'll go ahead and update
the remaining modules that I have to be consistent with the PR comments
provided here.
Modules in this commit:
Modules that I will contribute in follow on PRs:
As I continue working on this project I expect to contribute more modules as the need for them arises in my work.
Relevant Backlog Issue #89