Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle maps in clone #1164

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Handle maps in clone #1164

merged 1 commit into from
Aug 4, 2022

Conversation

yorinasub17
Copy link
Contributor

Description

Fixes a bug in the Clone function of the terraform.Options struct where map objects were not being deep cloned, causing side effects.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Fixed a bug in the Clone function of the terraform.Options struct where map objects were not being deep cloned, causing side effects.

rhoboat
rhoboat approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhoboat rhoboat mentioned this pull request Aug 4, 2022
Closed
@yorinasub17
Copy link
Contributor Author

Thanks for review! Test failures are unrelated to this change, so will go ahead and merge this in!

@yorinasub17 yorinasub17 merged commit 3e7eac6 into master Aug 4, 2022
@yorinasub17 yorinasub17 deleted the bug/clone-env-vars branch August 4, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhoboat rhoboat rhoboat approved these changes

@zackproser zackproser Awaiting requested review from zackproser

@denis256 denis256 Awaiting requested review from denis256

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorinasub17 @rhoboat