Potential issue with global flags

[rhoboat]

We might have to fix this line for newer versions of Terraform.

terratest/modules/terraform/init.go

Line 20 in 49466ad

args := []string{"init", fmt.Sprintf("-upgrade=%t", options.Upgrade)}

This was observed today when using Terraform 1.2.6 with Terratest v0.40.17:

TestUpgradeModules 2022-08-02T19:48:14Z retry.go:91: terraform [init -upgrade=true]
TestUpgradeModules 2022-08-02T19:48:14Z logger.go:66: Running command terraform with args [init -upgrade=true]
TestUpgradeModules 2022-08-02T19:48:14Z logger.go:66: �[31mUsage: terraform [global options] init [options]

Full logs are in a test run on Linux_amd64 in terraform-aws-ecs: https://app.circleci.com/pipelines/github/gruntwork-io/terraform-aws-ecs/484/workflows/f2783998-c28b-4bbb-af75-09df063c3d4b/jobs/3577/artifacts (see docker-fargate-service-with-alb.log)

Testing locally on darwin_amd64 with 1.2.x versions, terraform init -upgrade and terraform init -upgrade=true work.

This issue is still being investigated so we may find out there is something else going on here.
If this is in fact an issue, we'll have to update all documentation (release notes, etc) where we advise users to run terraform init -upgrade.

[rhoboat]

Closing at this issue was found to have been caused by another function adding unsupported CLI args to this call.

[rhoboat]

The underlying error was fixed by #1164