-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HttpHelper methods that accept options structs #1078
Conversation
@denis256 I do see 2 options to stay safe:
Personally I would prefer 1) as it gives flexibility. |
@dkuzmenok the changes in this PR already account for the scenario you mentioned. If you take a look at terratest/modules/http-helper/http_helper.go Lines 352 to 357 in 0acf7fc
|
@tonerdo Strange I did not notice that, when I was tracing method calls. Then it looks fine. Thanks. |
This PR adds option classes for the HttpHelper methods so that it can be more easily extended in a backwards compatible way.
Addresses #902