Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backwards Incompatible] Use options classes for HttpHelper methods #1055

Closed
wants to merge 10 commits into from

Conversation

tonerdo
Copy link
Contributor

@tonerdo tonerdo commented Feb 1, 2022

This PR adds option classes for the HttpHelper methods so that it can be more easily extended in a backwards compatible way.

Addresses #902

@elgatito
Copy link

elgatito commented Mar 2, 2022

@brikis98 @tonerdo I would take into consideration the idea of using context instead of a custom timeout and move that into a separate method, then call from old methods (with current method signatures) new methods that use contexts.

@tonerdo
Copy link
Contributor Author

tonerdo commented Mar 9, 2022

Closing this in favour of #1078

@tonerdo tonerdo closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants