Simplify CopyTerraformFolderToTemp by using CopyTerraformFolderToDest #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
|
Looks like the related tests are failing, so going to close this temporarily while i work through the issues |
|
Reopening as I got the tests to pass now. Also fixes a bug in |
yorinasub17
force-pushed
the
feature/improve-copy
branch
from
deef5db to
bf7d84e
Compare
yorinasub17
force-pushed
the
feature/improve-copy
branch
from
bf7d84e to
a5546cc
Compare
denis256
approved these changes
Feb 27, 2022
|
Thanks for review! Going to merge this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1054 to simplify the logic of
test_structure.CopyTerraformFolderToTemp.