add support for providing a dest folder for tf copy #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott1138
requested review from
ina-stoyanova,
infraredgirl,
marinalimeira and
robmorgan
as code owners
tonerdo
suggested changes
Feb 1, 2022
tonerdo
approved these changes
Feb 2, 2022
tonerdo
previously requested changes
Feb 2, 2022
tonerdo
suggested changes
Feb 2, 2022
yorinasub17
reviewed
Feb 3, 2022
yorinasub17
reviewed
Feb 3, 2022
tonerdo
approved these changes
Feb 6, 2022
|
I can't see why the tests failed. I ran the Go tests locally and they passed. Any insights? |
|
@scott1138 Looks like there are some flaky tests. Looking into it |
|
@tonerdo anything I can do to help? |
|
@tonerdo Sorry to pester, just following up. The team that manages our agents doesn't like that I am writing data outside of my build directory, so I am hoping we can get this merged soon. |
yorinasub17
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function similar to CopyTerraformFolderToTemp called CopyTerraformFolderToDest that allows providing a destination folder other than temp. This is useful when running on a build agent where a failure in the tests occurs and files are abandoned in the temp folder. With large provider downloads across multiple tests this can cause space issues.