Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Tags' and supporting functions to VPC struct #1000

Merged

Conversation

SphenicPaul
Copy link
Contributor

Summary

Updated vpc.go. and vpc_test.go to include support for Tags to resolve #995 (just for VPC, not Subnet):

  • Vpc struct now has additional, Tags property
  • Added additional GetTagsForVpc() and GetTagsForVpcE() functions (to obtain tags for VPC)
  • Added additional GetTagValueForVpc() and GetTagValueForVpcE() functions (to obtain tag value for VPC tag)
  • Tests added for GetTagsForVpc() and GetTagValueForVpc().
  • Test added for GetTagValueForVpcE() to assert error where no tag of specific key exists

Test Evidence

image

@SphenicPaul
Copy link
Contributor Author

Please shout if you've any questions/suggestions etc. - I'm relatively new to Go but I've tried to follow conventions already present within the module.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This mostly LGTM. Had a few nits, mostly around style. Once addressed, I think this is good to go!

Let me kick off a regression test build so you have one test cycle.

modules/aws/vpc.go Outdated Show resolved Hide resolved
modules/aws/vpc.go Outdated Show resolved Hide resolved
@SphenicPaul
Copy link
Contributor Author

SphenicPaul commented Oct 1, 2021

Thanks @yorinasub17 - Updated those now.

Let me know if there are any further tweaks/changes required,

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM! The build failed, but the test failures are known flaky tests that are unrelated to these changes, so can merge this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No 'GetTagsForVpc()', helper function (and other 'GetTags...' functions)
2 participants