-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'Tags' and supporting functions to VPC struct #1000
Added 'Tags' and supporting functions to VPC struct #1000
Conversation
… 'Vpc' struct and 'GetVpcsE' function.
Please shout if you've any questions/suggestions etc. - I'm relatively new to Go but I've tried to follow conventions already present within the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This mostly LGTM. Had a few nits, mostly around style. Once addressed, I think this is good to go!
Let me kick off a regression test build so you have one test cycle.
Thanks @yorinasub17 - Updated those now. Let me know if there are any further tweaks/changes required, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM! The build failed, but the test failures are known flaky tests that are unrelated to these changes, so can merge this in!
Summary
Updated
vpc.go.
andvpc_test.go
to include support forTags
to resolve #995 (just forVPC
, notSubnet
):Vpc
struct now has additional,Tags
propertyGetTagsForVpc()
andGetTagsForVpcE()
functions (to obtain tags for VPC)GetTagValueForVpc()
andGetTagValueForVpcE()
functions (to obtain tag value for VPC tag)GetTagsForVpc()
andGetTagValueForVpc()
.GetTagValueForVpcE()
to assert error where no tag of specific key existsTest Evidence