Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No 'GetTagsForVpc()', helper function (and other 'GetTags...' functions) #995

Closed
SphenicPaul opened this issue Sep 23, 2021 · 1 comment · Fixed by #1000
Closed

No 'GetTagsForVpc()', helper function (and other 'GetTags...' functions) #995

SphenicPaul opened this issue Sep 23, 2021 · 1 comment · Fixed by #1000
Labels
AWS enhancement New feature or request

Comments

@SphenicPaul
Copy link
Contributor

SphenicPaul commented Sep 23, 2021

There doesn't appear to be any helper function for obtaining the 'Tags' for AWS VPCs - There seems to be something similar for AWS EC2 instances in here but nothing for AWS VPCs.

Additionally, I suspect there are other resources that would benefit from being able to obtain the tags so these can be tested as part of builds/tests etc. - Subnet, users, roles etc. are others - Actually, there doesn't seem to be a file/script for 'subnet(s)' within this 'AWS' module - Is it worth creating one to support this initial functionality I have (or is there something located somewhere else that I'm missing)?

I might create a PR for some of the resources I initially require tags for but I just want to ensure that these would be suitable/wanted. Resources supporting tagging are on this page.

Shout if you've any questions.

@yorinasub17 yorinasub17 added AWS enhancement New feature or request help wanted labels Sep 24, 2021
@yorinasub17
Copy link
Contributor

I think that is reasonable! For VPC, I might prefer updating the Vpc struct that gets returned by the getter functions to include the tags.

Although these functions most likely fail the Complexity litmus test mentioned in type of contributions we accept, we have a hidden criteria of Completeness, and retrieving tags so you can check them is a basic function of most testing, so it makes sense to add them in under that criteria.

PRs to add these are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWS enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants