Fix error wrapping for errors in HTTP2 server preface #6639
Mergeable / Mergeable
failed
Mar 30, 2024 in 0s
3/3 Fail(s): LABEL, DESCRIPTION, MILESTONE
Status: FAIL
Here are some stats of the run:
3 validations were ran.
0 PASSED
3 FAILED
Details
❌ Validator: LABEL
- ❌ label does not include "^Type:"
Input : Status: Requires Reporter Clarification,stale
Settings :{"must_include":{"regex":"^Type:"}}
❌ Validator: DESCRIPTION
- ❌ description does not include "^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$"**
Input : # What?
This PR fixes the error wrapping that happens in the server preface and a test for it.
The test emulates communication when the client uses an incapable certificate (it's valid, but only can be used for email protection).
Why?
Without the fix commit the Dial will do constant retries till the context is canceled.
Resolves: #6593
Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}
❌ Validator: MILESTONE
- ❌ milestone does not include "Release$"
Input :
Settings :{"must_include":{"regex":"Release$"}}
Loading