Fix error wrapping for errors in HTTP2 server preface #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
olegbespalov
commented
Sep 15, 2023
olegbespalov
force-pushed
the
fix/error-wrapping
branch
from
b5d0ef0 to
71e7646
Compare
|
😢 Okay, so the test is flaky, and there are cases where the expected error still does not fail fast, and it tries to connect again I probably need to investigate it deeper 😢 |
|
Thanks for your contribution. Let us know when this is ready for review and please check comments above to sign the CLA. |
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the error wrapping that happens in the server preface and a test for it.
The test emulates communication when the client uses an incapable certificate (it's valid, but only can be used for email protection).
Why?
Without the fix commit the Dial will do constant retries till the context is canceled.
Resolves: #6593