Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " channelz: stage 4 - add security and socket option info" #2124

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

lyuxuan
Copy link
Contributor

@lyuxuan lyuxuan commented Jun 6, 2018

Reverts #2098

Appengine will fail with the error below:

go-app-builder: Failed parsing input: parser: bad import "syscall" in google.golang.org/grpc/channelz/funcs.go from GOPATH

The root cause of it is in type_linux.go.

import (
"syscall"
"golang.org/x/sys/unix"
)

@menghanl menghanl merged commit 96cefb4 into master Jun 6, 2018
@menghanl menghanl deleted the revert-2098-security_metric_fix branch June 6, 2018 01:04
@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants