channelz: stage 4 - add security and socket option info #2098
Conversation
|
Review status: 0 of 19 files reviewed at latest revision, all discussions resolved, some commit checks failed. channelz/types_nonlinux.go, line 1 at r1 (raw file):
Add an Comments from Reviewable |
lyuxuan
force-pushed
the
security_metric_fix
branch
from
5994dee to
4265c7d
Compare
lyuxuan
force-pushed
the
security_metric_fix
branch
from
4265c7d to
9637fb8
Compare
|
Review status: all files reviewed at latest revision, all discussions resolved. channelz/util_test.go, line 2 at r3 (raw file):
Why is this 1.10? channelz/service/service_test.go, line 1 at r3 (raw file):
Only the socket related tests are platform specific, other tests should cover all platforms. test/channelz_linux_go19_test.go, line 1 at r3 (raw file):
The file name is And why is this go1.10 and above only? Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 3 unresolved discussions. channelz/util_test.go, line 2 at r3 (raw file): Previously, menghanl (Menghan Li) wrote…
This is because SyscallConn() function for net.TCPListener is added after go1.10. golang/go@eed308d channelz/service/service_test.go, line 1 at r3 (raw file): Previously, menghanl (Menghan Li) wrote…
yeah, make sense. I split the test into 3 files, the base service_test.go which contains all the shared tests, service_linux_test.go, which contains linux necessary helper functions and tests, service_nonlinux_test.go, which contains nonlinux helper functions. test/channelz_linux_go19_test.go, line 1 at r3 (raw file): Previously, menghanl (Menghan Li) wrote…
Wrong file name, should be go1.10. Good catch. Comments from Reviewable |
|
Review status: 19 of 23 files reviewed at latest revision, 2 unresolved discussions. channelz/util_test.go, line 2 at r3 (raw file): Previously, lyuxuan wrote…
Add comment to explain this. channelz/service/service_linux_test.go, line 20 at r4 (raw file):
Add file level comment for what's different between this and non-linux. test/channelz_linux_go19_test.go, line 1 at r3 (raw file): Previously, lyuxuan wrote…
Is this 1.10 the same reason as above? Add a comment as well. Comments from Reviewable |
|
Review status: 19 of 23 files reviewed at latest revision, 3 unresolved discussions. channelz/util_test.go, line 2 at r3 (raw file): Previously, menghanl (Menghan Li) wrote…
done channelz/service/service_linux_test.go, line 20 at r4 (raw file): Previously, menghanl (Menghan Li) wrote…
done test/channelz_linux_go19_test.go, line 1 at r3 (raw file): Previously, menghanl (Menghan Li) wrote…
yes. done Comments from Reviewable |
) Reverts #2098 Appengine will fail with the error below: ``` go-app-builder: Failed parsing input: parser: bad import "syscall" in google.golang.org/grpc/channelz/funcs.go from GOPATH ``` The root cause of it is in type_linux.go. https://github.com/grpc/grpc-go/blob/629f6bc5e559f3a278d922c79f46678030797db3/channelz/types_linux.go#L21-L25
split socketopt as a separate package
fix the build tags that previously break users.
Socketoption is only supported on linux system, as
GetsockoptTCPInfois only defined for linux environment.This change is