-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for national buses and ferries of Nicaragua #130
base: master
Are you sure you want to change the base?
Conversation
Yeah, nice progress here! I would like to see #83 going in before also. This list of providers is getting long now. |
I've changed the configuration to allow ferries, too (simply removed |
This PR needs to be rebased on the latest commits to the code and modified to stick to the newly introduced naming conventions (see #83 for more information) for selectors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! All depending PRs have been accepted. So this is probably ready to be merged.
Cool, that there is now support for ferries!!
@xamanu so you don't want to have this merged until there's tests for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed, In my opinion every (new) creator should now include tests.
This will be a good reference implementation for a new city, based on the standard creators.
In case #136 gets merged in, I'd be happy to provide the missing tests here. Just waiting for the direction we are taking there. |
This PR only adds the minimal
config.json
used by the standard creators. However, to successfully produce the countrywide GTFS, it depends on #114, #124, #125, #126 and (to clean the data up) on #127.Those PRs should be merged first.