Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of #104 to improve color handling and move essential parts into the core part of osm2gtfs. This PR includes:
Line
objects'route_color
attributes are now a hex value (and shouldn't be different things).colour
information is sanitized (checked and eventually converted from W3C color names to hex values).route_text_color
can be obtained from OSM by using theref:colour_tx
tag. This seems to be the most appropriate, when looking at the wiki. Of course creators are free to use any other tag.RoutesCreator
computes it's ownroute_text_color
, based on a smart logic found by @ialokim and implemented within the helper functioncalculate_color_of_contrast
. Of course creators can override this standard creator behaviour to define the colors and the logic as they want/need.This PR is based on #99 (data structure).