Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give reserve attributes consistent names. #275

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Give reserve attributes consistent names. #275

merged 3 commits into from
Mar 31, 2022

Conversation

darrylmelander
Copy link
Collaborator

@darrylmelander darrylmelander commented Mar 31, 2022 •
edited
Loading

Summary/Motivation:

Some reserve attribute names follow a pattern (<reserve_name>_<suffix>) and some don't. This PR changes <reserve>_supplied attribute names so they all follow the pattern. This allows code to deal with reserves generically.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@darrylmelander
Give reserve attributes consistent names.
a3c97f5 
Reserve-related attributes now all start with the name of the reserve followed by a suffix. Applies to "_requirement", "_shortfall", "_price", and "_supplied" attributes. Renamed attributes are:

  rg => reserve_supplied
  reg_up_supplied => regulation_up_supplied
  reg_down_supplied => regulation_down_supplied
  flex_up_supplied => flexible_ramp_up_supplied
  flex_down_supplied => flexible_ramp_down_supplied
  spinning_supplied => spinning_reserve_supplied
  non_spinning_supplied => non_spinning_reserve_supplied
  supplemental_supplied => supplemental_reserve_supplied
@darrylmelander darrylmelander requested a review from bknueven March 31, 2022 18:30
bknueven
bknueven reviewed Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- I would like one small change to keep the names consistent.

bknueven
bknueven approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the baseline output jsons should be changed, but I need to do that as part of #273 anyways.

@bknueven bknueven enabled auto-merge March 31, 2022 20:11
@darrylmelander
Copy link
Collaborator Author

Ideally the baseline output jsons should be changed, but I need to do that as part of #273 anyways.

I can do that...

@bknueven bknueven merged commit 2a0ba8d into grid-parity-exchange:main Mar 31, 2022
@bknueven bknueven mentioned this pull request Apr 13, 2022
Merged
bknueven added a commit to bknueven/Prescient that referenced this pull request Apr 18, 2022
@bknueven
keeping up with grid-parity-exchange/Egret#275
40db417
darrylmelander pushed a commit to darrylmelander/Prescient that referenced this pull request Apr 18, 2022
@bknueven
keeping up with attribute rename in grid-parity-exchange/Egret#275 (#3)
aa73bae
darrylmelander pushed a commit to darrylmelander/Prescient that referenced this pull request Apr 18, 2022
@bknueven @darrylmelander
keeping up with attribute rename in grid-parity-exchange/Egret#275 (#3)
24e2ba5
darrylmelander pushed a commit to darrylmelander/Prescient that referenced this pull request May 5, 2022
@bknueven @darrylmelander
keeping up with attribute rename in grid-parity-exchange/Egret#275 (#3)
9ea9f0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bknueven bknueven bknueven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrylmelander @bknueven