Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reserve details #143

Merged
merged 2 commits into from
May 5, 2022
Merged

Support reserve details #143

merged 2 commits into from
May 5, 2022

Conversation

darrylmelander
Copy link
Collaborator

Support for reserves other than the generic system reserve:

  • Include reserve data in statistics gathering
  • Write reserves_details.csv to output, with one line per reserve product for each sced. Only reserve products present in the model should have a line written.

@darrylmelander darrylmelander linked an issue Mar 16, 2022 that may be closed by this pull request
Ancillary Service Support #34
Closed
bknueven
bknueven reviewed Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very reasonable.

If found a few more small things, and I still need to run the code. We should probably add a test for this functionality, but that can be for a subsequent PR.

prescient/engine/egret/data_extractors.py Outdated Show resolved Hide resolved
prescient/engine/egret/data_extractors.py Outdated Show resolved Hide resolved
prescient/engine/egret/egret_plugin.py Outdated Show resolved Hide resolved
prescient/simulator/oracle_manager.py Outdated Show resolved Hide resolved
prescient/simulator/tests/test_simulator.py Outdated Show resolved Hide resolved
@darrylmelander
Support additional reserve products:
4a05fa9 
* Track individual reserve products instead of always using generic reserve_requirement/rg
* Capture reserve details in stats, write to output csv.
@darrylmelander
Testing changes:
524766a 
* Fix test that was accidentally calling prescient twice
* Improve data type checking in test
* pin cbc version for GHA
* update comparison threshold
* More verbose error message when tests fail column comparisons
* mark macOS as expected failure
@darrylmelander darrylmelander force-pushed the reserve-detail branch 2 times, most recently from 270818f to 524766a Compare May 5, 2022 17:59
@darrylmelander darrylmelander enabled auto-merge May 5, 2022 18:01
@darrylmelander darrylmelander merged commit d9d668e into grid-parity-exchange:main May 5, 2022
@darrylmelander darrylmelander deleted the reserve-detail branch July 8, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bknueven bknueven bknueven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ancillary Service Support
2 participants
@darrylmelander @bknueven