Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix webpack config #1306

Merged
merged 2 commits into from
Jun 5, 2020
Merged

fix webpack config #1306

merged 2 commits into from
Jun 5, 2020

Conversation

wdh2100
Copy link
Collaborator

@wdh2100 wdh2100 commented Jun 3, 2020 •
edited
Loading

Build has too many logs. 😭
So reduce the log... change stats options(errors-warings)
ref : https://webpack.js.org/configuration/stats/

devserver host set localhost #1042

  • remove unused import (path)

What do you think?

thanks~

fix webpack config
cb63c8a 
- stats set errors-warings
- devserver host set localhost
- remove unused import (path)
@coveralls
Copy link

coveralls commented Jun 3, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 75.393% when pulling 7dfd8c1 on wdh2100:enhancement/webpack-config into b8eec4c on gregnb:v3.

@patorjk
Copy link
Collaborator

patorjk commented Jun 3, 2020

I agree with removing the unused import, are you also suggesting we change the stat param too? I'm think that would be good too. Moving it to "normal" from "verbose". None of the info "verbose" seems to be providing seems very useful.

rollback stats verbose
7dfd8c1 
add options(stat) for devServer
@wdh2100
Copy link
Collaborator Author

wdh2100 commented Jun 4, 2020

Moving it to "normal" from "verbose". None of the info "verbose" seems to be providing seems very useful.

"verbose" provide you useful information, right?

Is this right?

Then can I just change devServer(stat : error-waring)?
Too many logs on the development server.

@patorjk
Copy link
Collaborator

patorjk commented Jun 4, 2020

Sure, "errors-warnings" works. Also, I agree that the logs are a little much.

@patorjk patorjk added the v3 Denotes that this issue is required for v3 release of this library label Jun 4, 2020
@patorjk patorjk merged commit 4089328 into gregnb:v3 Jun 5, 2020
@patorjk patorjk mentioned this pull request Jun 5, 2020
Merged
@wdh2100 wdh2100 deleted the enhancement/webpack-config branch June 5, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3 Denotes that this issue is required for v3 release of this library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wdh2100 @coveralls @patorjk