Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open options to the webpack dev server #1042

Closed
wants to merge 1 commit into from

Conversation

wdh2100
Copy link
Collaborator

@wdh2100 wdh2100 commented Nov 1, 2019

https://webpack.js.org/configuration/dev-server/#devserveropen

Add open options to the webpack dev server

You can check it immediately when you run it(npm run dev)

https://webpack.js.org/configuration/dev-server/#devserveropen

Apply open options to the webpack dev server

You can check it immediately when you run it(npm run dev)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.308% when pulling 46d9e83 on wdh2100:patch-1 into 2d37c38 on gregnb:master.

@wdh2100 wdh2100 changed the title Apply open options to the webpack dev server Add open options to the webpack dev server Nov 1, 2019
@wdh2100
Copy link
Collaborator Author

wdh2100 commented Nov 1, 2019

What do you think about switching host '0.0.0.0' to 'localhost'

I think the developer will connect to http://localhost:5050

And I don't think anyone else is going to approach it(npm run dev)

ref: https://webpack.js.org/configuration/dev-server/#devserverhost

@gabrielliwerant gabrielliwerant added the needs review Useful to mark PRs for what's up next to review label Nov 6, 2019
@gabrielliwerant gabrielliwerant self-requested a review November 6, 2019 01:33
@gabrielliwerant
Copy link
Collaborator

gabrielliwerant commented Nov 19, 2019

Hello @wdh2100.

'localhost' is probably better than '0.0.0.0', so I'm ok with that change.

Regarding open by default, I wonder what the community feedback would be. For me personally, I actually prefer not opening by default, as it means I don't collect a bunch of extra tabs if I happen to stop/restart the server, which I do quite a bit when testing for various reasons.

@gabrielliwerant gabrielliwerant added community feedback and removed needs review Useful to mark PRs for what's up next to review labels Nov 19, 2019
@oliviertassinari
Copy link

oliviertassinari commented Nov 19, 2019

Regarding open by default, I wonder what the community feedback would be. For me personally, I actually prefer not opening by default, as it means I don't collect a bunch of extra tabs if I happen to stop/restart the server, which I do quite a bit when testing for various reasons.

I would prefer not to open by default as well.

@wdh2100 wdh2100 closed this Mar 14, 2020
@wdh2100 wdh2100 deleted the patch-1 branch March 14, 2020 13:44
@wdh2100 wdh2100 mentioned this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants