Fix 900 and refactored fixedHeaderOptions into fixedHeader and fixedSelectColumn #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2019
|
I noticed that the Material UI API refers to these types of parameters as "sticky" rather than "fixed". If this PR goes in, it may make sense to change:
|
|
Closing in favor of updates in v3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #900
It also refactors the fixedHeaderOptions into two parameters:
Both of these features work in Safari on Mac as well as in Chrome on the iPhone.
It also addresses the problem of text scrolling "under" a select box when the user scrolls the table horizontally. The fixedHeader example was updated to demonstrate the updates.