-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixedHeaderOptions not working when selectableRows='none' #1079
Comments
Hey @GuyShaanan, I'm having difficulty reproducing. Modifying the Can you create a codesandbox to help me reproduce the problem? |
Your gif shows it perfectly- the "Name" column which is the first column isn't "fixed" in place. It scrolls when you scroll horizontaly, when it should actually stay in place. |
Actually, that behavior is intentional, and as far as I can tell, it has always worked that way. The fixed y-axis behavior means that whatever column you are over is the column header that shows. It will not show a "Name" header once you've scrolled past "Name" and are looking at "Title." I believe that doing otherwise would cause more confusion, as the header would not correspond to the column that shows. If you remove the fixed y-axis behavior, you will not see the header stick to the column, it will just scroll past. Maybe that's the behavior you're looking for? |
I updated the original message to be more readable: Now set Am I misinterpreting that feature? That stickiness of the column header text is a known feature and I'm not referring to it in this ticket). Thanks! Edit: |
Hopefully this clears it up. The intended behavior of xAxis is as follows:
To test the behavior of these, you need enough columns and small enough view to generate horizontal scroll bars. In my testing, everything works here exactly as intended. |
Great, thanks, that clears the issue. Also- why would it make sense to only make the checkboxes column sticky, but not the first column when |
Agreed, it's not clear from the API that |
Just an FYI, this bug is still present in the table: #900 I was about to submit a PR to fix it (I have it fixed in my mui-dt repo), but I noticed the API change. The bug described in that ticket is a bad bug, the table does not work right in "scroll" mode in Safari. Because of how "position: sticky" works in Safari, I don't think you can achieve all of the modes you described above. I would recommend a partial revert of the API change. Instead of discarding fixedHeader, I'd change it to only govern the stickiness of the header, and then add an option called "fixedLeft" that defaulted to true that governed if the select column was sticky. Any changes to this really should be tested in Safari on a Mac, since the implementation of "sticky" is different in that browser. Also, if you have an iPhone, you can use Chrome and see the same bug listed in the ticket I mentioned. |
Hi, any news on this one? I do have the same problem and this fix would save my day... Regards. |
Thanks for the feature, it is really useful.
Expected Behavior
When
selectableRows == 'none'
the first column (whatever it is) should stay in view when scrolling horizontally with settingCurrent Behavior
When the first column isn't the row selection checkboxes column- the first column doesn't stay in view when you scroll horizontally.
Steps to Reproduce (for bugs)
fixedHeaderOptions
demo.selectableRows: 'none'
tooptions
.Your Environment
The text was updated successfully, but these errors were encountered: