Package.json overhaul #1077
Closed
Package.json overhaul #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielliwerant
added
the
needs review
gabrielliwerant
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
❤️ ❤️ ❤️ This is great! So nice to have all the packages updated. Everything seemed to work for me. This is probably the most important part piece of the v3 update at this point. Will mark as such and merge it in with others after handling any other major issues/deprecations with upgrade. There might be a release or two before v3, so leaving off the lgtm tag for now.
gabrielliwerant
added
breaking change
bug
enhancement
v3
|
Marked as breaking change mostly for any material v4 changes, like the padding. |
- Fix formatting errors in docs - Add additional deprecation information - Provide data mapping example - Improve clarity around what some options do
Should prevent deprecation warnings from appearing frivolously based on default options, and should allows smoother transition in the next major version update.
* Fix issues caused by style changes for dense table views We need something closer to the previous styles for default stacked views to prevent divergences in display with mui v4 * Fix deprecation warning in example
…b#1003) * Change tooltip structure to prevent overlap and simplify logic * Further simplify logic, removing state for tooltip
* Prevent object reference issues with textLabels by creating new objects We should return a new object when getting text label information so that we don't unintentionally reuse the same object. as it can be altered by options, thus leading to bugs * Update tests to use new object factory for textLabels
…ch is already open (gregnb#1053) * Reset `activeIcon` to `null` when Search button is clicked while search is already open * Add assertion tests about `iconActive` * Insert conditional check to not hide search when there is a query, and maintain active state so long as there is a query * Allow search icon to show as active when `searchOpen` is set to `true` in initial options * Code Clarity Updates - Segmented logic from inline JSX into separate click handler method - Reworked `getActiveIcon` to have a single return * Adding two additional tests
gregnb#1059) * fix(gregnb#444): table download should show column 'label' in output csv, not 'name' * fix: default to using column.name if label doesn't exist
* Only show deprecation warnings in dev mode. * Hide deprecation warnings * Add warn deprecated function to hide unless dev. * Run prettier, change dep notice, revert text labels change * Console error
* Fix deprecation warnings in examples * Fix prop duplication on component
* Properly propagate options wjem computing the displayed row Also propagates default filter type when none is provided in the column options. This was the intended behavior, as alluded to in the documentation for the column option, but was not implemented * Simplify custom filter list logic and prevent double calls to renderer * Update custom filters example to demonstrate custom multiselect
* Move props from the `div` to the `input` Fixing the Accessibility issue with the input not having an appropriate aria-label. * Made requested change
* Decouple height from responsive options Allows some flexibility in case height becomes a separate option * Add full width responsive scroll option Allows fixed header to operate as well as fix issues where the width of the table overflows the browser window * Add responsive stacked full width option Mirrors the responsive scroll full width option to allow fixed header to behave properly * Update documentation for new responsive options
* Escapes certain initial characters in csv data to prevent injection * Add tests for csv injection escaping
...near the beginning of page. It provides an easier navigation, otherwise it's tiresome to scroll back and forth.
Should help to clear up confusion that filterList must be array of arrays, which is the same type as the filterList in the main column options
Correct the wrong example
…tables into package_upgrade
|
Closing in favor of updates in v3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the packages and removes vulnerabilities. It updates the peer dep of React and Material UI to more recent versions. The tests have also been updated to work with the latest packages.
I've resisted making too many changes. This PR should go with this one: #949
mui/material-ui#15928 - Reason for updating TableToolbarSelect.js and one of its tests.
First brought up here: #1065