Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tooltip structure to prevent overlap and simplify logic #1003

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Change tooltip structure to prevent overlap and simplify logic #1003

merged 3 commits into from
Dec 6, 2019

Conversation

gabrielliwerant
Copy link
Collaborator

@gabrielliwerant gabrielliwerant commented Oct 12, 2019 •
edited
Loading

Closes #1001.

@gabrielliwerant gabrielliwerant added bug v3 Denotes that this issue is required for v3 release of this library labels Oct 12, 2019
@coveralls
Copy link

coveralls commented Oct 12, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 76.517% when pulling c705cf3 on bugfix/issue-1001-sort-tooltip into 80d3ab5 on master.

@gabrielliwerant gabrielliwerant added lgtm and removed lgtm labels Oct 15, 2019
@gabrielliwerant
Merge branch 'master' of https://github.com/gregnb/mui-datatables int…
c705cf3 
…o bugfix/issue-1001-sort-tooltip

# Conflicts:
#	src/components/TableHeadCell.js
@gabrielliwerant gabrielliwerant merged commit 4041cff into master Dec 6, 2019
@gabrielliwerant gabrielliwerant deleted the bugfix/issue-1001-sort-tooltip branch December 6, 2019 18:52
lalong13 pushed a commit to lalong13/mui-datatables that referenced this pull request Jan 15, 2020
@gabrielliwerant @lalong13
Change tooltip structure to prevent overlap and simplify logic (gregn…
3d1e1ef 
…b#1003)

* Change tooltip structure to prevent overlap and simplify logic

* Further simplify logic, removing state for tooltip
patorjk pushed a commit to patorjk/mui-datatables that referenced this pull request May 31, 2020
@gabrielliwerant @patorjk
Change tooltip structure to prevent overlap and simplify logic (gregn…
09274e1 
…b#1003)

* Change tooltip structure to prevent overlap and simplify logic

* Further simplify logic, removing state for tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug lgtm v3 Denotes that this issue is required for v3 release of this library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to disable 'Sort' tooltip / hint?
2 participants
@gabrielliwerant @coveralls