Hide toggle button when the row is not expandable #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
|
I don't want to force this behavior by default, and it's not how the parallel feature of row selection works, see my comment on your issue for another way to move forward here. |
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
|
PTAL @gabrielliwerant and let me know if you have further requests! Thanks. |
Signed-off-by: Try Ajitiono <[email protected]>
gabrielliwerant
added
needs review
gabrielliwerant
requested changes
Nov 16, 2019
gabrielliwerant
added
enhancement
needs work
and removed
needs review
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
Signed-off-by: Try Ajitiono <[email protected]>
src/components/TableBody.js
Outdated
| @@ -240,6 +240,11 @@ class TableBody extends React.Component { | |||
| fixedHeader={options.fixedHeader} | |||
| checked={this.isRowSelected(dataIndex)} | |||
| expandableOn={options.expandableRows} | |||
| // When rows are expandable and selectable, but this row isn't expandable, set this to enabled. | |||
There was a problem hiding this comment.
This comment is probably out of date now that we no longer check for selectable, right?
There was a problem hiding this comment.
iuhh correct, I will delete the selectable part.
There was a problem hiding this comment.
Updated it! let me know what you think.
Signed-off-by: Try Ajitiono <[email protected]>
gabrielliwerant
approved these changes
Nov 19, 2019
pgoforth
added a commit
to pgoforth/mui-datatables
that referenced
this pull request
Nov 25, 2019
…/activeIcon-for-search-not-reset-on-toggle * 'master' of github.com:gregnb/mui-datatables: 2.13.0 Prettify files Feature/issue 1036 fixed header (gregnb#1071) Update webpack dev server and related dependencies (gregnb#1069) Feature/issue 871 (setCellHeaderProps) and Feature/issue 714 (setTableProps) (gregnb#889) Feature/issue 937 array and custom update filter support (gregnb#1067) Bugfix/issue 1052 csv download issues (gregnb#1064) Hide toggle button when the row is not expandable (gregnb#1025) add test case to verify reset type (gregnb#1006) Update .gitignore and adding yarn.lock (gregnb#1004) Serverside sorting example (gregnb#986) No Pointer style cursor for table head when no hint or sorting (gregnb#910) Added disableToolbarSelect option (gregnb#874) Add table properties option (gregnb#670)
lalong13
pushed a commit
to lalong13/mui-datatables
that referenced
this pull request
Jan 15, 2020
* add more expandableOn condition to prevent toggle button render Signed-off-by: Try Ajitiono <[email protected]> * hide toggle button if row is not expandable Signed-off-by: Try Ajitiono <[email protected]> * Create unobtrusive change instead Signed-off-by: Try Ajitiono <[email protected]> * Add example Signed-off-by: Try Ajitiono <[email protected]> * Revert old example and disable prettier while saving Signed-off-by: Try Ajitiono <[email protected]> * cleanup Signed-off-by: Try Ajitiono <[email protected]> * Remove unnecessary width style Signed-off-by: Try Ajitiono <[email protected]> * Remove options selectable rows from hideExpandButton prop Signed-off-by: Try Ajitiono <[email protected]> * Only have one example Signed-off-by: Try Ajitiono <[email protected]> * Remove example Signed-off-by: Try Ajitiono <[email protected]> * Update comment Signed-off-by: Try Ajitiono <[email protected]> * update comment again Signed-off-by: Try Ajitiono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1023. Adds a class
MUIDataTableSelectCell-expandDisabledto the expand button, whenisRowExpandable(dataIndex)returnsfalse.This allows us to hide the
IconButton[shown by default] -- and therefore, won't break existing behavior.Medias
Expandable toggle button -- does not have class
Non-expandable toggle button - has class
expandDisabledGIF of the Example
In this GIF, I will show case 2 examples -- the new example for the hidden button one, and the existing example (just to show the current features are not breaking).