Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore and ignoring yarn.lock #1004

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

n3tr
Copy link
Contributor

@n3tr n3tr commented Oct 14, 2019

from #997

Since we are using NPM as a package manager right now, better adding yarn.lock to .gitignore to prevent unintentionally committing it.

I also add some other files to align with http://gitignore.io/api/node

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.36% when pulling cb452f3 on n3tr:update-gitignore-yarnlock into b8bee52 on gregnb:master.

@gabrielliwerant gabrielliwerant added the needs review Useful to mark PRs for what's up next to review label Oct 14, 2019
@gabrielliwerant gabrielliwerant self-requested a review October 14, 2019 18:39
@gabrielliwerant gabrielliwerant added enhancement lgtm and removed needs review Useful to mark PRs for what's up next to review labels Nov 6, 2019
Copy link
Collaborator

@gabrielliwerant gabrielliwerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for adding this!

@gabrielliwerant gabrielliwerant merged commit 5e5cf5a into gregnb:master Nov 21, 2019
pgoforth added a commit to pgoforth/mui-datatables that referenced this pull request Nov 25, 2019
…/activeIcon-for-search-not-reset-on-toggle

* 'master' of github.com:gregnb/mui-datatables:
  2.13.0
  Prettify files
  Feature/issue 1036 fixed header (gregnb#1071)
  Update webpack dev server and related dependencies (gregnb#1069)
  Feature/issue 871 (setCellHeaderProps) and Feature/issue 714 (setTableProps) (gregnb#889)
  Feature/issue 937 array and custom update filter support (gregnb#1067)
  Bugfix/issue 1052 csv download issues (gregnb#1064)
  Hide toggle button when the row is not expandable (gregnb#1025)
  add test case to verify reset type (gregnb#1006)
  Update .gitignore and adding yarn.lock (gregnb#1004)
  Serverside sorting example (gregnb#986)
  No Pointer style cursor for table head when no hint or sorting (gregnb#910)
  Added disableToolbarSelect option (gregnb#874)
  Add table properties option (gregnb#670)
lalong13 pushed a commit to lalong13/mui-datatables that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants