v3 #195

gregberge · 2018-09-30T14:11:45Z

Summary

See commits.

- Add "runtimeConfig" option to enable or disable runtime configuration BREAKING CHANGE: - Runtime configuration is always loaded (even with Node API `convert`) - In CLI, "--config" is now "--config-file"; this new option can be used everywhere Closes #192

This will fix all SVGO issues. BREAKING CHANGE: runtime configuration is now loaded using webpack loader. Fixes #177. Fixes #188.

This will fix all SVGO issues. BREAKING CHANGE: runtime configuration is now loaded using rollup plugin. Fixes #177 Fixes #188

Closes #190

vercel · 2018-09-30T14:11:47Z

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Removing style tag is an optimization, SVGO can do it better than us. BREAKING CHANGE: Style tag will no longer be automatically removed. SVGO should handle it correctly using "inlineStyles" plugin. If you want to remove them, enable "removeStyleElement" plugin in your SVGO config. Closes #191

Also improve template documentation. Closes #187

TrySound · 2018-09-30T14:17:48Z

I'm not a fun of Svg prefix. Can this be disabled optionally?

codecov · 2018-09-30T14:18:32Z

Codecov Report

Merging #195 into master will decrease coverage by 1.14%.
The diff coverage is 82.11%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   86.88%   85.74%   -1.15%     
==========================================
  Files          26       24       -2     
  Lines         488      519      +31     
  Branches       91      103      +12     
==========================================
+ Hits          424      445      +21     
- Misses         59       66       +7     
- Partials        5        8       +3

Impacted Files	Coverage Δ
packages/rollup/src/index.js	`100% <ø> (ø)`	⬆️
packages/core/src/convert.js	`100% <100%> (ø)`	⬆️
packages/core/src/templates/reactDomTemplate.js	`100% <100%> (ø)`	⬆️
packages/core/src/h2x/expandProps.js	`100% <100%> (ø)`	⬆️
packages/core/src/templates/reactNativeTemplate.js	`77.41% <100%> (+0.75%)`	⬆️
packages/cli/src/util.js	`66.66% <100%> (-4.77%)`	⬇️
packages/core/src/plugins/h2x.js	`100% <100%> (ø)`	⬆️
packages/core/src/config.js	`100% <100%> (+22.22%)`	⬆️
packages/core/src/plugins/prettier.js	`100% <100%> (ø)`	⬆️
packages/webpack/src/index.js	`95.45% <100%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b687c9e...a29f45a. Read the comment docs.

gregberge · 2018-09-30T14:18:58Z

@TrySound what is the problem with that?

TrySound · 2018-09-30T14:22:03Z

I use only named exports and wouldn't like to consider icons like something special. I already use icons directory for that. Plain name is enough. Svg prefix is a bit opinionated

gregberge · 2018-09-30T14:23:21Z

@TrySound we only use the default export. So I don't see what is the problem. I suggest you to edit your template and remove Svg prefix.

TrySound · 2018-09-30T14:28:32Z

Okay, if it doesn't affect file name I will just slice prefix.

gregberge · 2018-09-30T14:29:01Z

@TrySound yeah it is just the component name to avoid problem like "Infinity =".

TrySound · 2018-09-30T14:32:34Z

forwardRef implementation is not quite useful. The point is that ref can be builtin option. You suggest to wrap component with React.forwardRef in every usage.

I suggest something like this

import React from 'react';

export default React.forwardRef((props, ref) =>
  <SvgIcon {...props} svgRef={ref} />
)

gregberge · 2018-09-30T14:34:44Z

@twm what is the difference between this and my implementation?

TrySound · 2018-09-30T14:36:53Z

I don't see you apply React.forwardRef

import React from 'react';

export default (props, ref) =>
  <SvgIcon {...props} svgRef={ref} />

gregberge · 2018-09-30T14:38:22Z

@TrySound https://svgr-mduwqvjvwf.now.sh/

All good except that I forgot React.forwardRef()...

TrySound · 2018-09-30T14:39:47Z

And? You just name variable forwardRef.

gregberge · 2018-09-30T14:40:33Z

@TrySound yes, I will name it "ForwardRef" in fact, because it is a component.

gregberge · 2018-09-30T14:41:10Z

const ForwardRef = React.forwardRef((props, ref) => ...)
export default ForwardRef

TrySound · 2018-09-30T14:42:03Z

Yes, this is what library should produce.

BREAKING CHANGE: "ref" option now uses `React.forwardRef`. You don't have to use "svgRef" prop, just use "ref" and it will work. `React.forwardRef` requires React > 16.3. Closes #184

BREAKING CHANGE: `svgAttributes` has been removed, please use `svgProps` instead. Closes #173

BREAKING CHANGE: "--no-expand-props" is now replaced by "--expand-props none". You can now specify a position "start" or "end" for "expandProps" property. Closes #170

You can now use `svgr.sync` to call svgr synchronously! Closes #185

Also fix option in website.

This fix incompatible options, "--no-dimensions" will be prioritary. Fixes #141

See #184

Closes #183

gregberge added 4 commits September 30, 2018 15:00

fix(webpack): forward filePath in webpack loader

b7a108e

This will fix all SVGO issues. BREAKING CHANGE: runtime configuration is now loaded using webpack loader. Fixes #177. Fixes #188.

fix(rollup): forward filePath in rollup plugin

461492b

This will fix all SVGO issues. BREAKING CHANGE: runtime configuration is now loaded using rollup plugin. Fixes #177 Fixes #188

feat: always prefix component name with "Svg"

f71aa7a

Closes #190

gregberge added 2 commits September 30, 2018 16:12

feat(template): expose getProps util for template

5cb238e

Also improve template documentation. Closes #187

gregberge force-pushed the next branch from bebc0ae to 666c757 Compare September 30, 2018 14:15

gregberge force-pushed the next branch from c969a84 to 44981f5 Compare September 30, 2018 14:35

gregberge added 5 commits September 30, 2018 16:45

feat: use React.forwardRef

cbee51c

BREAKING CHANGE: "ref" option now uses `React.forwardRef`. You don't have to use "svgRef" prop, just use "ref" and it will work. `React.forwardRef` requires React > 16.3. Closes #184

feat: remove "svgAttributes" option

4e46a5d

BREAKING CHANGE: `svgAttributes` has been removed, please use `svgProps` instead. Closes #173

chore: enable now at deploy

d51da18

chore(lint): remove unused variable

9869055

chore(website): fix build with now

b0a3cd0

gregberge force-pushed the next branch from 44981f5 to b0a3cd0 Compare September 30, 2018 14:45

gregberge added 2 commits September 30, 2018 20:07

feat: new "expandProps" option

bb95828

BREAKING CHANGE: "--no-expand-props" is now replaced by "--expand-props none". You can now specify a position "start" or "end" for "expandProps" property. Closes #170

feat: add synchronous API

169eb2f

You can now use `svgr.sync` to call svgr synchronously! Closes #185

gregberge force-pushed the next branch from 76ee3e3 to ed2d80f Compare September 30, 2018 19:19

fix: fix expandProps when position is not allowed

45522fc

Also fix option in website.

gregberge force-pushed the next branch from ed2d80f to 45522fc Compare September 30, 2018 19:22

gregberge added 3 commits September 30, 2018 21:27

fix: fix --icon + --no-dimensions

7535693

This fix incompatible options, "--no-dimensions" will be prioritary. Fixes #141

feat: use forwardRef on React Native

4bdd989

See #184

docs(jest): document how to use with Jest

a29f45a

Closes #183

gregberge merged commit 42a4524 into master Oct 1, 2018

gregberge deleted the next branch October 1, 2018 17:54

This was referenced Nov 25, 2023

[Snyk] Security upgrade @svgr/core from 2.4.1 to 4.0.0 Bhanditz/svgr#55

Open

[Snyk] Security upgrade @svgr/core from 2.4.1 to 4.0.0 Bhanditz/svgr#56

Open

[Snyk] Security upgrade @svgr/core from 2.4.1 to 4.0.0 Bhanditz/svgr#57

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3 #195

v3 #195

gregberge commented Sep 30, 2018

vercel bot commented Sep 30, 2018

TrySound commented Sep 30, 2018

codecov bot commented Sep 30, 2018 •

edited

Loading

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018 •

edited

Loading

gregberge commented Sep 30, 2018 •

edited

Loading

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

v3 #195

v3 #195

Conversation

gregberge commented Sep 30, 2018

Summary

vercel bot commented Sep 30, 2018

TrySound commented Sep 30, 2018

codecov bot commented Sep 30, 2018 • edited Loading

Codecov Report

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018 • edited Loading

gregberge commented Sep 30, 2018 • edited Loading

TrySound commented Sep 30, 2018

gregberge commented Sep 30, 2018

gregberge commented Sep 30, 2018

TrySound commented Sep 30, 2018

codecov bot commented Sep 30, 2018 •

edited

Loading

TrySound commented Sep 30, 2018 •

edited

Loading

gregberge commented Sep 30, 2018 •

edited

Loading