Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.svgrrc is never called from rollup or webpack. #177

Closed
vwxyutarooo opened this issue Sep 18, 2018 · 2 comments
Closed

.svgrrc is never called from rollup or webpack. #177

vwxyutarooo opened this issue Sep 18, 2018 · 2 comments

Comments

@vwxyutarooo
Copy link
Contributor

🐛 Bug Report

As is title, .svgrrc is never called from rollup or webpack. Is this Right? Is this habit to expected? If it's not, or someone think this is good idea to able to do this, I'm thinking I'll create patch PR.

To Reproduce

Versions

"@svgr/rollup": "2.3.0"
"@svgr/webpack": "2.3.0"

Relate codes and PR

Expected behavior

Link to repl or repo (highly encouraged)

Run `npx envinfo --system --binaries --npmPackages

@gregberge
Copy link
Owner

This is not the expected behaviour. .svgrrc should be enable for Rollup plugin and webpack loader. PR welcome to fix it.

gregberge added a commit that referenced this issue Sep 30, 2018
This will fix all SVGO issues.

BREAKING CHANGE: runtime configuration is now loaded using rollup plugin.

Fixes #177
Fixes #188
@xwchris
Copy link
Contributor

xwchris commented Oct 11, 2018

webpack still can't read svgr config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants