Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Revert #83 #84

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Change: Revert #83 #84

merged 1 commit into from
Nov 20, 2023

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Nov 20, 2023

What

Revert #83, which added connection options in a hardcoded way.
Jira: SC-960

Why

With greenbone/openvas-scanner#1355 this options can be added when calling wmic or wmi via the library, and currently defaults to [sign]. This hardcoded options collide with the default or provided one.

For testing with wmic:

wmic -d 7 -U domain/user%pass //192.168.0.1[sign,seal] "SELECT name FROM Win32_ComputerSystem"

or using openvas-nasl

host = get_host_ip();
usrname = get_kb_item( "SMB/login" );
passwd  = get_kb_item( "SMB/password" );
opts = "[sign,seal]";

handle = wmi_connect( host:host, username:usrname, password:passwd, options:opts);

References

Jira: SC-960

Checklist

  • Tests

@jjnicola jjnicola requested a review from a team as a code owner November 20, 2023 14:08
@ArnoStiefvater ArnoStiefvater merged commit b5d2f78 into main Nov 20, 2023
6 checks passed
@ArnoStiefvater ArnoStiefvater deleted the revert-83 branch November 20, 2023 14:30
@jjnicola jjnicola mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants