Skip to content

Commit

Permalink
Change: Revert #83 (#84)
Browse files Browse the repository at this point in the history
## What
Revert #83, which added connection options in a hardcoded way.
<!--
  Describe what changes are being made, e.g. which feature/bug is being
  developed/fixed in this PR? How did you verify the changes in this PR?
-->

## Why
With greenbone/openvas-scanner#1355 this options can be added when
calling wmic or wmi via the library, and currently defaults to [sign].
This hardcoded options collide with the default or provided one.

For testing:
```
wmic -d 7 -U domain/user%pass //192.168.0.1[sign,seal] "SELECT name FROM Win32_ComputerSystem"
```
or 
```
``
<!-- Describe why are these changes necessary? -->

## References

<!-- Add identifier for issue tickets, links to other PRs, etc. -->

## Checklist

<!-- Remove this section if not applicable to your changes -->

- [ ] Tests
  • Loading branch information
ArnoStiefvater authored Nov 20, 2023
2 parents 7afc44d + 9069f50 commit b5d2f78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion samba/lib/com/dcom/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ static struct composite_context *dcom_determine_rpc_binding(
if (!NT_STATUS_IS_OK(status))
{
/* build a binding string using NCACN_IP_TCP */
char *bindstr = talloc_asprintf(c, "ncacn_ip_tcp:%s[sign,seal]", server);
char *bindstr = talloc_asprintf(c, "ncacn_ip_tcp:%s", server);
if (composite_nomem(bindstr, c)) return c;

status = dcerpc_parse_binding(c, bindstr, &activation_state->binding);
Expand Down

0 comments on commit b5d2f78

Please sign in to comment.