Add target's alive test method before starting a scan #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
approved these changes
Jan 20, 2020
mattmundell
requested changes
Jan 20, 2020
src/manage.c
Outdated
| @@ -4103,6 +4104,10 @@ launch_osp_openvas_task (task_t task, target_t target, const char *scan_id, | |||
| hosts_str = target_hosts (target); | |||
| ports_str = target_port_range (target); | |||
| exclude_hosts_str = target_exclude_hosts (target); | |||
|
|
|||
| if (target_alive_tests (target) >= 0) | |||
There was a problem hiding this comment.
alive_test should be init'd if condition is false.
jjnicola
force-pushed
the
alive-test
branch
2 times, most recently
from
289e1cb
to
947e092
Compare
mattmundell
requested changes
Jan 20, 2020
src/manage.c
Outdated
| @@ -4071,6 +4071,7 @@ launch_osp_openvas_task (task_t task, target_t target, const char *scan_id, | |||
| { | |||
| osp_connection_t *connection; | |||
| char *hosts_str, *ports_str, *exclude_hosts_str, *finished_hosts_str; | |||
| int alive_test = 0; | |||
There was a problem hiding this comment.
For consistency, please keep initialisations out of the declaration block in gvmd. Like how config and connection are done below.
I know some places in gvmd do it, but I've been trying to prevent new code from doing it because it got messy.
mattmundell
approved these changes
Jan 20, 2020
|
@mattmundell Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on pr greenbone/gvm-libs#312