Merge gvmd-9.0 changes into master #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses issues with the start time being undefined while the status is already set to "Running", e.g. during sensor scans.
The variable "started" is now initialized separately for consistency.
The get_system_report_types function did not fetch the scanner type so it erroneously assumed it was handling an OSP scanner instead.
Setting it to SCANNER_TYPE_NONE was redundant.
This is meant to prevent repeating status changes to "Running".
Previously the default stop_task_internal was used for this scanner type, so the scans were not stopped correctly.
When using get_reports to test an alert, details will always be enabled as events and test_alert also always include report details.
This fixes hosts not being added to the assets correctly, vulnerabilities not being included or duplicated in the syncAttribute elements if the same vulnerability was found multiple times on different hosts. The version number is updated to 3.2.0.
The XML generated by the XSL stylesheet would be embedded into the GMP element, so the XML declaration should be omitted.
mattmundell
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes from the following PRs: #948, #949, #951, #955, #962, #964, #965
The alive test and reverse lookup options are already handled in master with #947 and #959, so the PRs #936, #943 and #958 are excluded.
Checklist: